[Buildroot] [PATCH 2/2 v2] system: use Etc/UTC as default timezone
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Tue Jul 4 07:01:52 UTC 2017
Hello,
On Tue, 4 Jul 2017 08:56:39 +0200, Yann E. MORIN wrote:
> Even though no timezone implicitly means UTC, systemd is not all that
> happy when it does not have a timezone set. This is all fine on a RW
> filesystem because systemd will create a symlink on its own (to
> Etc/UTC), but not so much on a RO filesystem, causing all kind of
> issues at boot time (up to the point that the system is unusable).
>
> We fix that by requiring that the timezone is actually set. The check is
> done by verifying that the timezone file is an actual file; if not set,
> the test would find a directory and would thus fail.
>
> Update the help entry accordingly.
>
> Also fix indentation in tzdata.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Cc: Richard Braun <rbraun at sceen.net>
> Cc: Alexandre Belloni <alexandre.belloni at free-electrons.com>
> Cc: Martin Bark <martin at barkynet.com>
> Cc: Maxime Hadjinlian <maxime.hadjinlian at gmail.com>
>
> ---
> Changes v1 -> v2:
> - don't accept an empty value as meaning the default; enforce that
> (Arnout)
> - comit log mentions indentation cleanups (Arnout)
As discussed IRL, I have changed the commit title. Indeed, Etc/UTC is
already the default timezone. What this patch does is prevent the user
from selecting an empty value for the timezone.
Applied with the commit title fixed. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list