[Buildroot] [PATCH] package/linuxptp: remove incdefs.sh to avoid cross-compilation issues

Petr Kulhavy brain at jikos.cz
Thu Jul 6 21:50:19 UTC 2017


Hi Romain,

On 06/07/17 19:06, Romain Naour wrote:
>> What else was exactly failing in your case? Maybe there are some improvements I
>> can propose to the package mainstream?
> While looking at the issue I made some changes that make me believe that
> CROSS_COMPILE was not defined while incdefs.sh was called.
>
> With Yann, we looked at the issue after I published this patch to the mailing
> list. We fixed the build issue and I'll send a v2 shortly.
>
> But, we think that greping in a header is not a good practice.
> To check if a define is available or not the build system should try to build a
> small code including the header. A build system like autotools and CMake can be
> used to do so.
>
> Maybe you can try to upstream a new build system ?
I fully agree with you that this grep approach is very weak. I have 
already tried to propose changes that compile bits of code like 
autotools do.
Unfortunately the owner of linuxptp almost religiuosly rejects the 
autotools approach. He is convinced that autotools are bad and can't see 
that the grep approach is not portable and cannot work reliably.
He rather prefers to finetune the grep expressions, instead of accepting 
the de-facto industry standard.

The only thing that seems to work is to point out concrete 
configurations and environments where the compilation fails and 
persistently report issues to him.
I can take over this inconvenient job of a postman, but need a concrete 
input from you.

Thanks and regards
Petr




More information about the buildroot mailing list