[Buildroot] [PATCH v2 2/2] package/linuxptp: set KBUILD_OUTPUT to STAGING_DIR

Arnout Vandecappelle arnout at mind.be
Thu Jul 6 22:51:12 UTC 2017



On 07-07-17 00:03, Petr Kulhavy wrote:
> Thanks Romain, that looks very good.

 You can do more formal review by replying with:

 Reviewed-by: Your Full Name <your at email.address>

below the Signed-off-by. This will be recorded in patchwork and in git.

 Of course, you should only do so if you have actually reviewed the patch in detail.

 If you have tested it, you can add:

 Tested-by: Your Full Name <your at email.address>
 (details of what you tested)

 Regards,
 Arnout


> 
> Petr
> 
> On 06/07/17 19:43, Romain Naour wrote:
>> incdefs.sh try to define some flags with user_flags() and kernel_flags()
>> functions. The later is looking at the kernel headers installed on the host
>> when KBUILD_OUTPUT is not set. If no kernel headers are installed on the host,
>> the grep fail and HAVE_ONESTEP_SYNC is not set on the command line:
>> see: grep: /usr/include/linux/net_tstamp.h: No such file or directory
>> So the missing.h define HWTSTAMP_TX_ONESTEP_SYNC which is also present in the
>> kernel headers installed in STAGING_DIR (toolchain w/ headers >= 3.2).
>>
>> Indeed KBUILD_OUTPUT is empty because it's reset in the makefile, so move
>> KBUILD_OUTPUT in the enviroment while calling "make"/
>>
>> Also set KBUILD_OUTPUT to STAGING_DIR to find net_tstamp.h.
>>
>> While at it, use the same arguments for BUILD_CMD and INSTALL_TARGET_CMD.
>>
>> Thanks to Yann for the live review during the Buildroot summer camp.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/364/36470db2c262d2e1fda5144a08cfe221831e093e
>>
>>
>> Signed-off-by: Romain Naour <romain.naour at smile.fr>
>> Cc: Petr Kulhavy <brain at jikos.cz>
>> Cc: "Yann E. MORIN" <yann.morin.1998 at free.fr>
>> ---
>> v2: rework BUILD_CMD and INSTALL_TARGET_CMD to avoid patching makefile
>> ---
>>   package/linuxptp/linuxptp.mk | 8 ++++++--
>>   1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/package/linuxptp/linuxptp.mk b/package/linuxptp/linuxptp.mk
>> index 0fc85b0..d8bcc2b 100644
>> --- a/package/linuxptp/linuxptp.mk
>> +++ b/package/linuxptp/linuxptp.mk
>> @@ -13,8 +13,9 @@ LINUXPTP_LICENSE_FILES = COPYING
>>   define LINUXPTP_BUILD_CMDS
>>       $(TARGET_MAKE_ENV) \
>>       CROSS_COMPILE="$(TARGET_CROSS)" \
>> +    KBUILD_OUTPUT=$(STAGING_DIR) \
>>       $(MAKE) \
>> -        KBUILD_OUTPUT=$(TARGET_DIR) \
>> +        prefix=/usr \
>>           EXTRA_CFLAGS="$(TARGET_CFLAGS)" \
>>           EXTRA_LDFLAGS="$(TARGET_LDFLAGS)" \
>>           -C $(@D) all
>> @@ -22,10 +23,13 @@ endef
>>     define LINUXPTP_INSTALL_TARGET_CMDS
>>       $(TARGET_MAKE_ENV) \
>> +    CROSS_COMPILE="$(TARGET_CROSS)" \
>> +    KBUILD_OUTPUT=$(STAGING_DIR) \
>>       $(MAKE) \
>>           prefix=/usr \
>>           DESTDIR=$(TARGET_DIR) \
>> -        $(TARGET_CONFIGURE_OPTS) \
>> +        EXTRA_CFLAGS="$(TARGET_CFLAGS)" \
>> +        EXTRA_LDFLAGS="$(TARGET_LDFLAGS)" \
>>           -C $(@D) install
>>         $(INSTALL) -D -m 644 $(LINUXPTP_PKGDIR)/linuxptp.cfg \
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF



More information about the buildroot mailing list