[Buildroot] [PATCH v8 03/10] support/scripts: add fix-rpath script to sanitize the rpath

[Thomas Petazzoni]

Hello,

On Thu, 20 Jul 2017 23:05:59 +0200, Arnout Vandecappelle wrote:

> >>  support/scripts/fix-rpath | 133 ++++++++++++++++++++++++++++++++++++++++++++++
> >>  1 file changed, 133 insertions(+)
> >>  create mode 100755 support/scripts/fix-rpath  
> > 
> > I've applied to master, after removing trailing slashes.  
> 
>  Which trailing slashes?

Gaah, I wanted to say "trailing spaces".

> > This is a little bit disturbing, so I believe it should be fixed in a
> > follow-up patch.  
> 
>  Right! That's because the "if ${PATCHELF} ..." just fails and the error is
> redirected to /dev/null.
> 
>  Better check if ${PATCHELF} is executable somewhere in the beginning.
> 
>  However, there is never a guarantee. If e.g. it would be missing a shared
> library, it would still fail in the same way. To be really sure, you'd have do
> e.g. call patchelf on itself to verify it is actually working.

Perhaps patchelf --help is sufficient?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com