[Buildroot] [PATCH v3] zstd: add new package

[Baruch Siach]

Hi Andrey,

On Mon, Jul 24, 2017 at 05:07:00PM -0700, Andrey Smirnov wrote:

[...]

> diff --git a/package/zstd/Config.in b/package/zstd/Config.in
> new file mode 100644
> index 0000000000..0e97c64e0a
> --- /dev/null
> +++ b/package/zstd/Config.in
> @@ -0,0 +1,13 @@
> +menuconfig BR2_PACKAGE_ZSTD
> +	bool "zstd"
> +	help
> +	  Zstandard, or zstd as short version, is a fast lossless
> +	  compression algorithm, targeting real-time compression
> +	  scenarios at zlib-level and better compression ratios
> +
> +	  For more info see https://facebook.github.io/zstd

The homepage link should come below ...

> +
> +	  The selection of other packages will enable some features:
> +
> +	  - xz, lz4 and/or zlib will enable support for corresponding
> +	    compression formats
> \ No newline at end of file

... here. It should be in a separate like that contains only the URL.

> diff --git a/package/zstd/zstd.hash b/package/zstd/zstd.hash
> new file mode 100644
> index 0000000000..d09e6b46f4
> --- /dev/null
> +++ b/package/zstd/zstd.hash
> @@ -0,0 +1,3 @@
> +# Locally computed
> +sha256 0fdba643b438b7cbce700dcc0e7b3e3da6d829088c63757a5984930e2f70b348 zstd-v1.3.0.tar.gz

Please add hashes for the license files.

> +
> diff --git a/package/zstd/zstd.mk b/package/zstd/zstd.mk
> new file mode 100644
> index 0000000000..ad26bae6fd
> --- /dev/null
> +++ b/package/zstd/zstd.mk
> @@ -0,0 +1,49 @@
> +################################################################################
> +#
> +# zstd
> +#
> +################################################################################
> +
> +ZSTD_VERSION = v1.3.0
> +ZSTD_SITE = $(call github,facebook,zstd,$(ZSTD_VERSION))
> +ZSTD_LICENSE = BSD-3-Clause

Maybe also mention the Facebook patents grant? I'm not sure about that because 
it is not strictly a code license, AFAIK, but it is related to "legal info".

Luca, what do you think?

> +ZSTD_LICENSE_FILES = LICENSE PATENTS

[...]

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -