[Buildroot] [PATCH 1/1] qt5declarative: backport 'Fix alignment issue on ARMv7' patch to 5.9.1

[Petar Koretic]

Hi Thomas.

I've added Signed-off-by and a link to the upstream bug to my buildroot
patch that adds the patch from the Qt commit that is linked.
You want me to add Signed-off-by and qt bug report link to the Qt patch?
Because in the end I just took the patch from the Qt commit in 5.9 upstream
branch so I have no affiliation to that.

Thanks,
Petar

On Mon, Jul 31, 2017 at 9:22 PM, Thomas Petazzoni <
thomas.petazzoni at free-electrons.com> wrote:

> Hello,
>
> On Mon, 31 Jul 2017 19:13:59 +0200, Petar Koretic wrote:
>
> > diff --git a/package/qt5/qt5declarative/0003-Fix-alignment-issue-on-ARMv7.patch
> b/package/qt5/qt5declarative/0003-Fix-alignment-issue-on-ARMv7.patch
> > new file mode 100644
> > index 0000000000..da68826ccb
> > --- /dev/null
> > +++ b/package/qt5/qt5declarative/0003-Fix-alignment-issue-on-ARMv7.patch
> > @@ -0,0 +1,34 @@
> > +From 03c2661b1243cc529fc3d8cfa65073f1da420307 Mon Sep 17 00:00:00 2001
> > +From: Simon Hausmann <simon.hausmann at qt.io>
> > +Date: Thu, 22 Jun 2017 13:34:09 +0200
> > +Subject: [PATCH] Fix alignment issue on ARMv7
> > +
> > +As analyzed in the bug report, it appears that we may get
> > +QV4::CompiledData::Function pointers for writing that are not aligned
> > +for the 64-bit fields at the beginning.
> > +
> > +[ChangeLog][QtQml] Fix crash due to misaligned data structures on ARMv7
> > +
> > +Task-number: QTBUG-61552
> > +Change-Id: I6b2c166b725496150c8850475577628ccd811d65
> > +Reviewed-by: Erik Verbruggen <erik.verbruggen at qt.io>
>
> You should add your Signed-off-by here, and a link to the upstream bug
> report or commit (I see you wrote the task number and change-id, but a
> direct link is preferable).
>
> Since anyway the patch was not entirely correct because it should be in
> the 5.9.1/ subfolder, can you resend an updated version that takes into
> account those small comments?
>
> Thanks a lot!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170731/5a014ef3/attachment-0002.html>