[Buildroot] [PATCH v1 1/2] package/libv4l: upstream patches for noMMU platform

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Fri Jun 9 10:01:42 UTC 2017


Hello,

On Fri, 9 Jun 2017 09:33:24 +0000, Hugues FRUCHET wrote:

> > Thanks a lot for those patches! It's mostly good, but I have a few
> > comments. First of all, both of your patches should be squashed into
> > just one, because they serve the same purpose: enabling libv4l on
> > nommu/static linking configurations.  
> 
> I have done it this way in order that you can easily revert the patch 
> 1/2 when bumping to v4l-utils 1.12.6 release (or 1.12.7, I don't know 
> the frequency of releases).
> The patch 2/2 is specific to buildroot and must remain.

When we bump a package version and patches need to be dropped, we don't
revert the commit that was adding them. We simply drop the patches in
the commit doing the version bump, and indicate in the commit log why
they are dropped (ideally with a reference to the upstream commit).

> >> +Subject: [PATCH 4/9] configure.ac: clarify configure summary  
> > 
> > Please generate the package/libv4l/ patch series with "git format-patch
> > -N" so  that the prefix is just [PATCH] and not [PATCH X/Y].  
> Will do ! I'll miss also the prefix [buildroot]...

Not sure what you mean by the "prefix [buildroot]". The [Buildroot] is
added by the mailing list software, and has nothing to do with how
patches are generated/applied.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com



More information about the buildroot mailing list