[Buildroot] [PATCH] syslinux: Add patch to build with the latest gnu-efi release

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Mon Jun 12 13:32:42 UTC 2017


Hello,

On Mon, 12 Jun 2017 15:20:32 +0200, Benoît Allard wrote:

> > The problem is that it builds a tool called "wrapper" with the
> > cross-compiler, and then tries to run it on the host. It might work if
> > your host and target use the same architecture and libc. Here, I'm
> > using the same architecture (x86-64) but not the same libc (glibc for
> > the host, uclibc for the target).
> > 
> > Do you think you could have a look?  
> 
> I just sent a patch about that. Thanks for noticing, and reporting the
> issue.

Thanks, I'll have a look.

> > Nit: please use 'git format-patch -N' to generate your patches. This
> > will generate patches with [PATCH] as a prefix instead of [PATCH X/Y].
> > Indeed, the 1/3, 2/3 and 3/3 in your patches don't make sense: your
> > patches are patches 7, 8 and 9! To avoid this, in Buildroot, we have
> > decided to not add numbering inside the patches themselves.
> >   
> 
> Maybe it would make sense to add the '-N' to the example command-lines
> in the manual ? ;) ( That would be section 21.5.2 and 21.5.4)

No, because those sections are about formatting patches for Buildroot,
not patches for packages.

But it should indeed be explained somewhere in the manual, i.e in
https://buildroot.org/downloads/manual/manual.html#patch-policy.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com



More information about the buildroot mailing list