[Buildroot] [PATCH 1/1] kvazaar: new package

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Jun 18 20:05:54 UTC 2017


Hello,

On Sat, 17 Jun 2017 01:29:27 +0200, Alexandre Esse wrote:
> Kvazaar is an open-source HEVC encoder licensed under LGPLv2.1.
> This provides tools to encode raw video into HEVC stream.
> 
> website: http://ultravideo.cs.tut.fi/
> 
> Signed-off-by: Alexandre Esse <alexandre.esse.dev at gmail.com>

I've applied, after doing a few changes. See below.

> diff --git a/package/kvazaar/Config.in b/package/kvazaar/Config.in
> new file mode 100644
> index 0000000..a720f17
> --- /dev/null
> +++ b/package/kvazaar/Config.in
> @@ -0,0 +1,4 @@
> +config BR2_PACKAGE_KVAZAAR
> +	bool "kvazaar"
> +	help
> +                An open-source HEVC encoder licensed under LGPLv2.1

Indentation for the help text is one tab + two spaces. Also, the
Config.in help text should have an URL of the upstream project.

Please run your package submissions through
support/scripts/check-package, it detects this kind of mistakes.

> +KVAZAAR_VERSION = v1.1.0
> +KVAZAAR_SITE = $(call github,ultravideo,kvazaar,$(KVAZAAR_VERSION))
> +KVAZAAR_LICENSE = LGPLv2.1

It's in fact LGPLv2.1+, and we use SPDX license codes in Buildroot, so
LGPL-2.1+.

> +KVAZAAR_LICENSE_FILES = COPYING
> +KVAZAAR_AUTORECONF = YES
> +KVAZAAR_INSTALL_STAGING = YES

I've added KVAZAAR_CONF_OPTS = --without-cryptopp to make sure it
doesn't pick up this optional dependency, as it's not explicitly
handled by kvazaar.mk.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com



More information about the buildroot mailing list