[Buildroot] [PATCH v4 1/6] board: Add support for Engicam i.CoreM6 DualLite/Solo boards

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Jun 20 05:46:35 UTC 2017


Hello,

On Tue, 20 Jun 2017 07:55:26 +0530, Jagan Teki wrote:

> >> -BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2017.05"
> >> -BR2_TARGET_UBOOT_BOARD_DEFCONFIG="imx6q_icore_mmc"
> >> +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2017.05-rc1"  
> >
> > This doesn't make sense. Why are you rolling back from 2017.05 to
> > 2017.05-rc1 ?
> >
> > I assume a feature present in the -rc1 is also present in the final
> > release. Otherwise, it means the feature has been reverted, which is a
> > bad sign.
> >
> > Maybe you wanted to use 2017.07-rc1 instead?  
> 
> Yes I need to use -rc1 because this feature is present in it. I was
> trying for explicitly applying patches, but those are more.

Did you read what I wrote? Your patch is using 2017.05-rc1, which is
most likely not what you intended, because 2017.05 final is available.
Wasn't your intention to use 2017.07-rc1.

Please re-read carefully your patch and my review. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com



More information about the buildroot mailing list