[Buildroot] [PATCH 1/2] uboot: add support for generating U-Boot boot scripts
Peter Korsgaard
peter at korsgaard.com
Thu Jun 22 14:18:03 UTC 2017
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:
Hi,
>> Makes sense to me. Committed, thanks.
> Wow, that was fast. I was wondering if we should extend it to multiple
> boot scripts, but then the syntax would be a bit horrible:
> BR2_TARGET_UBOOT_BOOT_SCRIPT_SOURCE="script1src:script1dest script2src:script2dest"
> We could still keep the compatibility by having:
> BR2_TARGET_UBOOT_BOOT_SCRIPT_SOURCE="script1src"
> just generate script1src and install it as boot.scr.
> Or maybe it's something we can take care of later?
Or alternatively use destfile = srcfile with extension replaced by .bin
>> > Retrospectively, I believe the choice of adding such a helper script
>> > for genimage was wrong. Having a proper option would be much
>> > cleaner/nicer IMO.
>>
>> Yes, agreed. My idea was also to add a kconfig option for it. This could
>> also have sub options like "support creating fat partitions" that would
>> pull in the needed host packages.
> Also my thinking.
>> The reason we went with the script solution was afaik that some projects
>> might want to extra processing before or after creating the image, so it
>> wasn't clear if it should run before or after the post-image scripts.
>>
>> You can argue though that for such "special" situations you should just
>> manually call genimage from the post-image script instead though.
> Absolutely. I don't think we should try in those options to cover *all*
> cases, only the most common ones. As long as the more special cases can
> be covered by custom logic in post-build/post-image scripts, we're good
> IMO.
Agreed!
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list