[Buildroot] [PATCH 1/1] package/gnuradio: link with libatomic when needed

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Jun 25 07:59:58 UTC 2017


Hello,

On Sun, 25 Jun 2017 08:57:41 +0200, Bernd Kuhls wrote:
> Fixes
> http://autobuild.buildroot.net/results/528/52825918bf65b23241cd68d99513350703469294/
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls at t-online.de>

Thanks for the patch. One question below.

> diff --git a/package/gnuradio/gnuradio.mk b/package/gnuradio/gnuradio.mk
> index 6407dd4f8..5d6ed8f92 100644
> --- a/package/gnuradio/gnuradio.mk
> +++ b/package/gnuradio/gnuradio.mk
> @@ -22,6 +22,7 @@ GNURADIO_DEPENDENCIES += orc
>  endif
>  
>  GNURADIO_CONF_OPTS = \
> +	-DCMAKE_CXX_FLAGS="$(TARGET_CXXFLAGS) $(GNURADIO_CXXFLAGS)" \

So we are now passing -march=armv7-a in CMAKE_CXX_CFLAGS..

> -GNURADIO_CONF_OPTS += -DCMAKE_C_FLAGS="$(TARGET_CFLAGS) -march=armv7-a"

..while it was passed in CMAKE_C_FLAGS before your patch. Is this
working OK? It would deserve a note in the commit log.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com



More information about the buildroot mailing list