[Buildroot] [PATCH] mtd: restore installation of libmtd to staging

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Wed Jun 28 06:29:08 UTC 2017


Hello,

Thanks for your patch!

On Tue, 27 Jun 2017 20:56:10 -0700, Andrey Yurovsky wrote:

> +define MTD_INSTALL_STAGING_CMDS
> +	$(INSTALL) -D -m 0755 $(@D)/include/libmtd.h $(STAGING_DIR)/usr/include/mtd/libmtd.h
> +	$(INSTALL) -D -m 0755 $(@D)/include/libubi.h $(STAGING_DIR)/usr/include/mtd/libubi.h
> +	$(INSTALL) -D -m 0755 $(@D)/include/mtd/ubi-media.h $(STAGING_DIR)/usr/include/mtd/ubi-media.h
> +	$(INSTALL) -D -m 0755 $(@D)/libmtd.a $(STAGING_DIR)/usr/lib/libmtd.a
> +	$(INSTALL) -D -m 0755 $(@D)/libubi.a $(STAGING_DIR)/usr/lib/libubi.a
> +endef
> +
>  $(eval $(autotools-package))
>  $(eval $(host-autotools-package))

Since it's an autotools package, it has a "make install" step that
should install those libraries. I believe that if the upstream mtd
doesn't install such useful libraries as part of its "make install"
step, then we should instead patch the upstream Makefile.am, and
contribute it upstream.

Best regards,

Thomas Petazzoni
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com



More information about the buildroot mailing list