[Buildroot] [PATCH 5/8 v3] tools: move size-stat-compare out of support/scripts/
Yann E. MORIN
yann.morin.1998 at free.fr
Fri Jun 30 21:50:09 UTC 2017
Move it to the top-level tools/ directory, so that it is easier to
find for users.
Add a legacy symlink for those users who already used them, so as
not to break their habits.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
Cc: Thomas De Schampheleire <patrickdepinguin at gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
Cc: Arnout Vandecappelle <arnout at mind.be>
---
support/scripts/size-stats-compare | 128 +------------------------------------
tools/readme.txt | 5 ++
tools/size-stats-compare | 127 ++++++++++++++++++++++++++++++++++++
3 files changed, 133 insertions(+), 127 deletions(-)
mode change 100755 => 120000 support/scripts/size-stats-compare
create mode 100755 tools/size-stats-compare
diff --git a/support/scripts/size-stats-compare b/support/scripts/size-stats-compare
deleted file mode 100755
index e5a1ec3f94..0000000000
--- a/support/scripts/size-stats-compare
+++ /dev/null
@@ -1,127 +0,0 @@
-#!/usr/bin/env python
-
-# Copyright (C) 2016 Thomas De Schampheleire <thomas.de.schampheleire at gmail.com>
-
-# This program is free software; you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation; either version 2 of the License, or
-# (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
-# General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
-
-# TODO (improvements)
-# - support K,M,G size suffixes for threshold
-# - output CSV file in addition to stdout reporting
-
-import csv
-import argparse
-import sys
-
-def read_file_size_csv(inputf, detail=None):
- """Extract package or file sizes from CSV file into size dictionary"""
- sizes = {}
- reader = csv.reader(inputf)
-
- header = next(reader)
- if (header[0] != 'File name' or header[1] != 'Package name' or
- header[2] != 'File size' or header[3] != 'Package size'):
- print(("Input file %s does not contain the expected header. Are you "
- "sure this file corresponds to the file-size-stats.csv "
- "file created by 'make graph-size'?") % inputf.name)
- sys.exit(1)
-
- for row in reader:
- if detail:
- sizes[row[0]] = int(row[2])
- else:
- sizes[row[1]] = int(row[3])
-
- return sizes
-
-def compare_sizes(old, new):
- """Return delta/added/removed dictionaries based on two input size
- dictionaries"""
- delta = {}
- oldkeys = set(old.keys())
- newkeys = set(new.keys())
-
- # packages/files in both
- for entry in newkeys.intersection(oldkeys):
- delta[entry] = ('', new[entry] - old[entry])
- # packages/files only in new
- for entry in newkeys.difference(oldkeys):
- delta[entry] = ('added', new[entry])
- # packages/files only in old
- for entry in oldkeys.difference(newkeys):
- delta[entry] = ('removed', -old[entry])
-
- return delta
-
-def print_results(result, threshold):
- """Print the given result dictionary sorted by size, ignoring any entries
- below or equal to threshold"""
-
- from six import iteritems
- list_result = list(iteritems(result))
- # result is a dictionary: name -> (flag, size difference)
- # list_result is a list of tuples: (name, (flag, size difference))
-
- for entry in sorted(list_result, key=lambda entry: entry[1][1]):
- if threshold is not None and abs(entry[1][1]) <= threshold:
- continue
- print('%12s %7s %s' % (entry[1][1], entry[1][0], entry[0]))
-
-
-# main #########################################################################
-
-description = """
-Compare rootfs size between Buildroot compilations, for example after changing
-configuration options or after switching to another Buildroot release.
-
-This script compares the file-size-stats.csv file generated by 'make graph-size'
-with the corresponding file from another Buildroot compilation.
-The size differences can be reported per package or per file.
-Size differences smaller or equal than a given threshold can be ignored.
-"""
-
-parser = argparse.ArgumentParser(description=description,
- formatter_class=argparse.RawDescriptionHelpFormatter)
-
-parser.add_argument('-d', '--detail', action='store_true',
- help='''report differences for individual files rather than
- packages''')
-parser.add_argument('-t', '--threshold', type=int,
- help='''ignore size differences smaller or equal than this
- value (bytes)''')
-parser.add_argument('old_file_size_csv', type=argparse.FileType('r'),
- metavar='old-file-size-stats.csv',
- help="""old CSV file with file and package size statistics,
- generated by 'make graph-size'""")
-parser.add_argument('new_file_size_csv', type=argparse.FileType('r'),
- metavar='new-file-size-stats.csv',
- help='new CSV file with file and package size statistics')
-args = parser.parse_args()
-
-if args.detail:
- keyword = 'file'
-else:
- keyword = 'package'
-
-old_sizes = read_file_size_csv(args.old_file_size_csv, args.detail)
-new_sizes = read_file_size_csv(args.new_file_size_csv, args.detail)
-
-delta = compare_sizes(old_sizes, new_sizes)
-
-print('Size difference per %s (bytes), threshold = %s' % (keyword, args.threshold))
-print(80*'-')
-print_results(delta, args.threshold)
-print(80*'-')
-print_results({'TOTAL': ('', sum(new_sizes.values()) - sum(old_sizes.values()))},
- threshold=None)
diff --git a/support/scripts/size-stats-compare b/support/scripts/size-stats-compare
new file mode 120000
index 0000000000..6336964a7a
--- /dev/null
+++ b/support/scripts/size-stats-compare
@@ -0,0 +1 @@
+../../tools/size-stats-compare
\ No newline at end of file
diff --git a/tools/readme.txt b/tools/readme.txt
index ba7a2058a4..4d6d5fb62c 100644
--- a/tools/readme.txt
+++ b/tools/readme.txt
@@ -17,6 +17,11 @@ get-developpers
of Buildroot, so they can be Cc:ed on a mail. Accepts a patch as
input, a package name or and architecture name.
+size-stat-compare
+ a script to compare the rootfs size between two differnt Buildroot
+ configurations. This can be used to identify the size impact of
+ a specific option, or of a set of specific options.
+
test-pkg
a script that tests a specific package against a set of various
toolchains, with the goal to detect toolchain-related dependencies
diff --git a/tools/size-stats-compare b/tools/size-stats-compare
new file mode 100755
index 0000000000..e5a1ec3f94
--- /dev/null
+++ b/tools/size-stats-compare
@@ -0,0 +1,127 @@
+#!/usr/bin/env python
+
+# Copyright (C) 2016 Thomas De Schampheleire <thomas.de.schampheleire at gmail.com>
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+# General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+
+# TODO (improvements)
+# - support K,M,G size suffixes for threshold
+# - output CSV file in addition to stdout reporting
+
+import csv
+import argparse
+import sys
+
+def read_file_size_csv(inputf, detail=None):
+ """Extract package or file sizes from CSV file into size dictionary"""
+ sizes = {}
+ reader = csv.reader(inputf)
+
+ header = next(reader)
+ if (header[0] != 'File name' or header[1] != 'Package name' or
+ header[2] != 'File size' or header[3] != 'Package size'):
+ print(("Input file %s does not contain the expected header. Are you "
+ "sure this file corresponds to the file-size-stats.csv "
+ "file created by 'make graph-size'?") % inputf.name)
+ sys.exit(1)
+
+ for row in reader:
+ if detail:
+ sizes[row[0]] = int(row[2])
+ else:
+ sizes[row[1]] = int(row[3])
+
+ return sizes
+
+def compare_sizes(old, new):
+ """Return delta/added/removed dictionaries based on two input size
+ dictionaries"""
+ delta = {}
+ oldkeys = set(old.keys())
+ newkeys = set(new.keys())
+
+ # packages/files in both
+ for entry in newkeys.intersection(oldkeys):
+ delta[entry] = ('', new[entry] - old[entry])
+ # packages/files only in new
+ for entry in newkeys.difference(oldkeys):
+ delta[entry] = ('added', new[entry])
+ # packages/files only in old
+ for entry in oldkeys.difference(newkeys):
+ delta[entry] = ('removed', -old[entry])
+
+ return delta
+
+def print_results(result, threshold):
+ """Print the given result dictionary sorted by size, ignoring any entries
+ below or equal to threshold"""
+
+ from six import iteritems
+ list_result = list(iteritems(result))
+ # result is a dictionary: name -> (flag, size difference)
+ # list_result is a list of tuples: (name, (flag, size difference))
+
+ for entry in sorted(list_result, key=lambda entry: entry[1][1]):
+ if threshold is not None and abs(entry[1][1]) <= threshold:
+ continue
+ print('%12s %7s %s' % (entry[1][1], entry[1][0], entry[0]))
+
+
+# main #########################################################################
+
+description = """
+Compare rootfs size between Buildroot compilations, for example after changing
+configuration options or after switching to another Buildroot release.
+
+This script compares the file-size-stats.csv file generated by 'make graph-size'
+with the corresponding file from another Buildroot compilation.
+The size differences can be reported per package or per file.
+Size differences smaller or equal than a given threshold can be ignored.
+"""
+
+parser = argparse.ArgumentParser(description=description,
+ formatter_class=argparse.RawDescriptionHelpFormatter)
+
+parser.add_argument('-d', '--detail', action='store_true',
+ help='''report differences for individual files rather than
+ packages''')
+parser.add_argument('-t', '--threshold', type=int,
+ help='''ignore size differences smaller or equal than this
+ value (bytes)''')
+parser.add_argument('old_file_size_csv', type=argparse.FileType('r'),
+ metavar='old-file-size-stats.csv',
+ help="""old CSV file with file and package size statistics,
+ generated by 'make graph-size'""")
+parser.add_argument('new_file_size_csv', type=argparse.FileType('r'),
+ metavar='new-file-size-stats.csv',
+ help='new CSV file with file and package size statistics')
+args = parser.parse_args()
+
+if args.detail:
+ keyword = 'file'
+else:
+ keyword = 'package'
+
+old_sizes = read_file_size_csv(args.old_file_size_csv, args.detail)
+new_sizes = read_file_size_csv(args.new_file_size_csv, args.detail)
+
+delta = compare_sizes(old_sizes, new_sizes)
+
+print('Size difference per %s (bytes), threshold = %s' % (keyword, args.threshold))
+print(80*'-')
+print_results(delta, args.threshold)
+print(80*'-')
+print_results({'TOTAL': ('', sum(new_sizes.values()) - sum(old_sizes.values()))},
+ threshold=None)
--
2.11.0
More information about the buildroot
mailing list