[Buildroot] [PATCH 1/5] core/pkg-cmake: provide our own platform description

[Arnout Vandecappelle]

On 01-03-17 19:43, Yann E. MORIN wrote:
> Arnout, All,
> 
> On 2017-03-01 09:35 +0100, Arnout Vandecappelle spake thusly:
>> On 01-03-17 09:17, Thomas Petazzoni wrote:
>>> Hello,
>>>
>>> On Wed, 1 Mar 2017 08:58:31 +0100, Arnout Vandecappelle wrote:
>>>
>>>>  Since you don't do any processing on the file, you could just use
>>>>
>>>> 		-DCMAKE_MODULE_PATH="$$(TOPDIR)/support/misc" \
>>>
>>> I think the idea is that since the Buildroot.cmake platform files gets
>>> referenced by the toolchainfile.cmake, then Buildroot.cmake anyway
>>> needs to be installed in $(HOST_DIR)/usr/share/buildroot, so we can
>>> just as well point CMake to this place.
>>>
>>>> and avoid copying the file around. Of course, in that case, support/cmake is
>>>> probably a better place to put the file :-)
>>>
>>> No: copying the file is needed, otherwise our toolchainfile.cmake file
>>> no longer works for people using it outside of Buildroot.
>>
>>  Good point. I still think it should be in staging rather than host, but for
>> sure it's more important to keep them together.
> 
> Why would you want it in staging? When we build our own internal cmake,
> the moduels it installs are so installed in host, not staging. They are
> build-description files, not target files.
> 
> Ergo, they should be in host, not staging.

 I was looking at it like the .pc files, which are in staging because they talk
about the target.

 About the modules: in fact, packages that install .cmake files will do that in
staging, not in host. So I do hope that cmake looks for them in staging as
well... That's what CMAKE_FIND_ROOT_PATH is for, isn't it?

 In fact, the only .cmake files I see installed in the host dir are:

- the Modules from CMake itself, but these are more related to the CMake
language, e.g. CheckIncludeFiles.cmake;

- the CMake files added by *host* packages;

- the CMake files added by buildroot which talk about *target* packages.

 So I stand by my original statement: I think the cmake files should move from
HOST/usr/share/buildroot to STAGING/usr/lib/cmake.

 Adding Samuel and Luca, our CMake "experts", to Cc.

 Regards,
 Arnout


> 
> Regards,
> Yann E. MORIN.
> 
>>  Therefore:
>>
>> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
>>
>>  Regards,
>>  Arnout
>>
>> -- 
>> Arnout Vandecappelle                          arnout at mind be
>> Senior Embedded Software Architect            +32-16-286500
>> Essensium/Mind                                http://www.mind.be
>> G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
>> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
>> GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF