[Buildroot] [PATCH 1/1] test-pkg: Extend the logfile with the first command as well

Yann E. MORIN yann.morin.1998 at free.fr
Thu Mar 9 22:05:37 UTC 2017


Thomas, All,

On 2017-03-09 23:02 +0100, Thomas Petazzoni spake thusly:
> On Thu, 9 Mar 2017 23:00:44 +0100, Yann E. MORIN wrote:
> > > > -    if ! make O="${dir}" olddefconfig >/dev/null 2>&1; then
> > > > +    if ! make O="${dir}" olddefconfig > "${dir}/logfile" 2>&1; then  
> > > 
> > > To be honest, I wasn't sure if we wanted > or >> here. It matters if
> > > you restart the test-pkg command after fixing issues. Do you want
> > > logfiles to contain the log of all previous builds, or just the current
> > > build?
> > > 
> > > For now, I've applied your patch as-is, with just ">", which means the
> > > logfile will only contain the output of the last build. It seems better
> > > to me this way, but we'll see if other folks disagree.  
> > 
> > Using append-redirection is what we should have used here, because the
> > logfile is already created a few lines above, for olddefconfig.
> 
> Hu? We're precisely changing the olddefconfig line in this patch. Am I
> missing something?

It looks liek I borked something when rebasing my remaining patches...

I'll double-check. Sorry for the noise...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'



More information about the buildroot mailing list