[Buildroot] [PATCH] kmscube: Move to the new repository

[Gary Bisson]

Hi,

On Thu, Mar 9, 2017 at 11:03 PM, Peter Korsgaard <peter at korsgaard.com> wrote:
>>>>>> "Gary" == Gary Bisson <gary.bisson at boundarydevices.com> writes:
>
> Hi,
>
>  >> I see them defined in two places here:
>  >>
>  >> $ grep -rn DRM_MODE_OBJECT_PLANE output/host/
>  >> output/host/usr/arm-buildroot-linux-uclibcgnueabihf/sysroot/usr/include/drm/drm_mode.h:336:#define
>  >> DRM_MODE_OBJECT_PLANE 0xeeeeeeee
>  >> output/host/usr/arm-buildroot-linux-uclibcgnueabihf/sysroot/usr/include/libdrm/drm_mode.h:336:#define
>  >> DRM_MODE_OBJECT_PLANE 0xeeeeeeee
>
>  > So it means your toolchain is using kernel headers >= 4.7.
>  > http://lxr.free-electrons.com/ident?v=4.6;i=DRM_MODE_OBJECT_PLANE
>  > http://lxr.free-electrons.com/ident?v=4.7;i=DRM_MODE_OBJECT_PLANE
>
>  > Not sure which header version the Linaro toolchain is using but it's
>  > definitely older than 4.7.
>
> Based on
> toolchain/toolchain-external/toolchain-external-linaro-arm/Config.in it
> is using 4.6.

Thanks.

>  > Thanks for testing it out, good to here it works but I'm still not
>  > sure adding this libdrm/drm_mode.h is the best solution as-is.
>
> The question is what happens if kmscube is run on a kernel that doesn't
> support DRM_MODE_OBJECT_PLANE (E.G. kernel < 4.7)?

I believe it would work since the declaration was in the kernel
already, just missing from the uapi header:
http://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?id=8812f38141

> If it really needs
> support for this then we should simply make the package depend on >= 4.7
> headers, and if not we could add a patch to add the include.

Adding a dependency on headers >= 4.7 would definitely work and I
think it's the easiest/cleanest option here.

I'll just be sad not to be able to use the prebuilt (linaro) toolchain ;)

Regards,
Gary