[Buildroot] [PATCH] libscrypt: -fPIC is needed to build for MIPS

Tue Mar 14 21:21:36 UTC 2017

Hello,

On Tue, 14 Mar 2017 15:40:02 +0000, Vicente Olivert Riera wrote:

> +# -fPIC is needed to build for MIPS
> +ifeq ($(BR2_mips)$(BR2_mipsel)$(BR2_mips64)$(BR2_mips64el),y)
> +LIBSCRYPT_CFLAGS += -fPIC
> +endif

This is not really the proper fix, because:

 1. -fPIC is not only needed for MIPS.

 2. The Makefile already passes -fPIC, but it gets overridden because
    Buildroot passes its own CFLAGS.

So I believe the patch proposed by Stefan Sørensen at
http://patchwork.ozlabs.org/patch/738605/ is a more appropriate
solution.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com