[Buildroot] binutils now adds sysroot for ld -rpath search

[Jörg Krause]

Hi Thomas,

On Tue, 2017-03-14 at 22:20 +0100, Thomas Petazzoni wrote:
> Hello,
> 
> On Tue, 14 Mar 2017 10:33:58 +0100, Jörg Krause wrote:
> 
> > After a discussion with Brad King on the CMake issue tracker [1]
> > about
> > how the linker should handle -rpath we agreed that ld should add
> > the
> > sysroot when searching for files (but not when setting the RPATH
> > header
> > value).
> > 
> > I picked up a five years old patch from the binutils mailing list
> > [2]
> > which already proposed the change, but was not submitted then.
> > 
> > I resend the patch [3] and this time Alan Modra accepted the
> > change. He
> > submitted two patches [4,5] which will add the sysroot to
> > -rpath for
> > absolute paths.
> 
> Aaah indeed. I also recently looked at some package that was failing
> to
> build because -rpath /usr/lib was passed. And then I realized that
> things were clunky: what if you really a RPATH to be encoded in the
> generated binary, but don't want this path to be looked at on the
> build
> machine during the cross-compilation.
> 
> Your patch solves exactly that. I guess we'll have to integrate it in
> Buildroot as well, but we will still have issues with external
> toolchains, sadly :-/

For now! But someday in the future all toolchains will use binutils at
least 2.29 (which will have the patch).

> Thanks a lot for this work!
> 

You're welcome! I just wanted to understand what the issue with rpath
is. I'm glad it will cause less trouble (when all toolchains are
updated).

Best regards,
Jörg