[Buildroot] [PATCH] libepoxy: EGL dependency is mandatory

[Romain Naour]

Le 19/03/2017 à 21:45, Romain Naour a écrit :
> Hi Vicente, Thomas, All,
> 
> Le 10/03/2017 à 16:05, Vicente Olivert Riera a écrit :
>> Hi Thomas,
>>
>> On 10/03/17 15:01, Thomas Petazzoni wrote:
>>> Hello,
>>>
>>> Cc'ing Gustavo, who said he would have a look at this issue.
>>
>> he already was on CC.
>>
>>> On Fri, 10 Mar 2017 11:11:50 +0000, Vicente Olivert Riera wrote:
>>>> The --disable-egl configure option doesn't exist:
>>>>
>>>> configure: WARNING: unrecognized options: [snip] --disable-egl
>>>>
>>>> If you don't have EGL support the configure script will fail like this:
>>>>
>>>> checking for EGL... no
>>>> configure: error: Package requirements (egl) were not met:
>>>>
>>>> Fixes:
>>>>   http://autobuild.buildroot.net/results/3eca5ba26a521f6cc5a611309ba066472af7769c
>>>>   http://autobuild.buildroot.net/results/cf9ec7da196d70548ae1413e4a3730314f6434d6
>>>>   http://autobuild.buildroot.net/results/069b80101afc4719db6d6d41cf5fc923be21ddc0
>>>>
>>>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera at imgtec.com>
>>>> ---
>>>>  package/libepoxy/Config.in   | 6 +++---
>>>>  package/libepoxy/libepoxy.mk | 9 +--------
>>>>  2 files changed, 4 insertions(+), 11 deletions(-)
>>>>
>>>> diff --git a/package/libepoxy/Config.in b/package/libepoxy/Config.in
>>>> index c87366a..54b8272 100644
>>>> --- a/package/libepoxy/Config.in
>>>> +++ b/package/libepoxy/Config.in
>>>> @@ -1,12 +1,12 @@
>>>>  config BR2_PACKAGE_LIBEPOXY
>>>>  	bool "libepoxy"
>>>>  	select BR2_PACKAGE_XUTIL_UTIL_MACROS
>>>> -	depends on BR2_PACKAGE_HAS_LIBEGL || BR2_PACKAGE_HAS_LIBGL
>>>> +	depends on BR2_PACKAGE_HAS_LIBEGL
>>>
>>> Really egl only is sufficient? This seems dubious. It doesn't need at
>>> least OpenGL ES ?
>>
>> I have successfully build tested it without Xorg and without OpenGL ES
>> support (just OpenGL EGL).
> 
> I'm using a x86 PC with HD6310 graphic card and mesa3d as OpenGL provider.
> In order to enable glamor in the X server, I selected libepoxy and had the build
> issue since libegl wasn't selected.
> Indeed, there is no option --disable-egl in libepoxy, and libegl is mandatory
> for Linux target.

Vincente, libepoxy use dlsym to load a GLES2 library when EGL support is
enabled, see src/dispatch_common.c

#define EGL_LIB "libEGL.so.1"
#define GLES1_LIB "libGLESv1_CM.so.1"
#define GLES2_LIB "libGLESv2.so.2"

So, OpenGL ES should be selected in the end.

Best regards,
Romain

> 
> Did you check the libepoxy reverse dependencies ?
> It seems we need to forward libegl dependency to libgtk3 package.
> 
> With that fixed:
> Reviewed-by: Romain Naour <romain.naour at gmail.com>
> Tested-by: Romain Naour <romain.naour at gmail.com>
> 
> Best regards,
> Romain
> 
>>
>> Vincent
>>
>>> Thomas
>>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>>
>