[Buildroot] [v5] package: add qt5virtualkeyboard
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Wed Mar 29 16:03:11 UTC 2017
Hello,
On Wed, 29 Mar 2017 11:58:22 -0400, Gaël PORTAY wrote:
> +QT5VIRTUALKEYBOARD_LANGUAGE_LAYOUTS = $(call qstrip,$(BR2_PACKAGE_QT5VIRTUALKEYBOARD_LANGUAGE_LAYOUTS))
> +QT5VIRTUALKEYBOARD_ALL_LAYOUTS = $(findstring all,$(QT5VIRTUALKEYBOARD_LANGUAGE_LAYOUTS))
> +ifneq ($(strip $(QT5VIRTUALKEYBOARD_LANGUAGE_LAYOUTS)),)
> +QMAKEFLAGS += CONFIG+="$(foreach lang,$(QT5VIRTUALKEYBOARD_LANGUAGE_LAYOUTS),lang-$(lang))"
> +
> +QT5VIRTUALKEYBOARD_OPENWNN = $(findstring ja_JP,$(QT5VIRTUALKEYBOARD_LANGUAGE_LAYOUTS))
> +ifneq ($(strip $(QT5VIRTUALKEYBOARD_OPENWNN)$(QT5VIRTUALKEYBOARD_ALL_LAYOUTS)),)
> +QT5VIRTUALKEYBOARD_LICENSE += Apache-2.0
This way of concatenating the licenses doesn't work, because the final
string will be:
"GPLv3 Apache-2.0"
while we want "GPLv3, Apache-2.0". Look at other Qt5 packages how they
are handling this:
QT5BASE_LICENSE := $(QT5BASE_LICENSE), BSD-3c (examples)
Note that next to the license, we also want an information on which
part of the package it applies.
> +QT5VIRTUALKEYBOARD_PINYIN = $(findstring zh_CN,$(QT5VIRTUALKEYBOARD_LANGUAGE_LAYOUTS))
> +ifneq ($(strip $(QT5VIRTUALKEYBOARD_PINYIN)$(QT5VIRTUALKEYBOARD_ALL_LAYOUTS)),)
> +QT5VIRTUALKEYBOARD_3RDPARTY_PARTS += pinyin
Do you really need the name here? You don't use it anywhere. What about:
QT5VIRTUALKEYBOARD_INSTALL_3RDPARTY = YES
instead.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
More information about the buildroot
mailing list