[Buildroot] [PATCH 1/1] libcsv: new package
Matthew Weber
matthew.weber at rockwellcollins.com
Mon May 1 19:29:41 UTC 2017
Thomas,
On Mon, May 1, 2017 at 2:27 PM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Hello,
>
> Thanks for this contribution, see some comments below.
>
> On Mon, 1 May 2017 12:37:20 -0500, Matt Weber wrote:
>
>> package/Config.in | 1 +
>> package/libcsv/Config.in | 10 ++++++++++
>> package/libcsv/libcsv.hash | 2 ++
>> package/libcsv/libcsv.mk | 15 +++++++++++++++
>
> Please add an entry to the DEVELOPERS file.
>
Will do.
>> +LIBCSV_VERSION = 3.0.3
>> +LIBCSV_SITE = http://sourceforge.net/projects/libcsv/files
>> +LIBCSV_SOURCE = libcsv-$(LIBCSV_VERSION).tar.gz
>
> Not needed, this is the default value.
Ah shoot, will update.
>
>> +LIBCSV_LICENSE = LGPLv2.1+
>
> Please use the SPDX license code: LGPL-2.1+
>
Will do.
>> +LIBCSV_LICENSE_FILES = COPYING.LESSER
>> +LIBCSV_INSTALL_STAGING = YES
>> +
>> +$(eval $(host-autotools-package))
>
> Why are you adding a host package ? If you don't intend to use it as a
> dependency for another package or don't have a good reason to have a
> host package, please don't add a host variant.
It's currently being used for a host side internal tool. We can
remove the host build and carry that internally as there isn't a
upstream reason to have it.
(Dave, care to update your MR and I'll resubmit?)
- Matt
More information about the buildroot
mailing list