[Buildroot] [PATCH v4 1/2] rhash: new package

Vicente Olivert Riera Vincent.Riera at imgtec.com
Tue May 9 09:39:00 UTC 2017


Hi Baruch,

On 09/05/17 10:32, Baruch Siach wrote:
> Hi Vicente,
> 
> On Tue, May 09, 2017 at 10:28:16AM +0100, Vicente Olivert Riera wrote:
>> +ifeq ($(BR2_PACKAGE_RHASH_BIN),y)
>> +# We also install the rhash console utility to the staging directory
>> +# since we want it to be a superset of the target directory.
> 
> And why is that?

http://lists.busybox.net/pipermail/buildroot/2017-April/189827.html

"And of course it doesn't matter if you install the program in staging
as well - in fact I prefer it, ideally staging is a superset of target."

Personally, since we are now doing the installation of the rhash console
utility manually via post-install-hooks, I wouldn't install it to
staging. But Arnout said that he prefer it to be installed to staging
because ideally is a superset of target. Nobody said the opposite so I
modified the patch following Arnout's advice.

Vincent

> 
>> +define RHASH_INSTALL_STAGING_RHASH_BIN
>> +	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
>> +		DESTDIR="$(STAGING_DIR)" $(RHASH_MAKE_OPTS) install-shared
>> +endef
>> +RHASH_POST_INSTALL_STAGING_HOOKS += RHASH_INSTALL_STAGING_RHASH_BIN
>> +define RHASH_INSTALL_TARGET_RHASH_BIN
>> +	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
>> +		DESTDIR="$(TARGET_DIR)" $(RHASH_MAKE_OPTS) install-shared
>> +endef
>> +RHASH_POST_INSTALL_TARGET_HOOKS += RHASH_INSTALL_TARGET_RHASH_BIN
>> +endif
> 
> baruch
> 



More information about the buildroot mailing list