[Buildroot] [PATCH 1/2] package: add python-raven

Joseph Kogut joseph.kogut at gmail.com
Fri Nov 3 19:08:43 UTC 2017


Thomas,

Thanks for the feedback,

> Please include the change to the DEVELOPERS file in the same patch, no
need to make it a separate patch.

The manual states at the end of section 21.5.1:

> If you are interested in getting notified of build failures and of further
> changes in the packages you added or modified, please add yourself to the
> DEVELOPERS file. This should be done in a separate patch of the series.

Did I misunderstand this section, or should the documentation be updated?

> It really doesn't have *any* runtime dependency on other Python
modules? I.e if you build just python-raven and the minimal python
interpreter, it works?

Now that you mention it, it doesn't have any external requirements,
but I'm unsure as to whether or not it requires any optional core
modules. I would assume that it needs urllib at least. I'll test it
and find out.

> Could you respin an updated version that
takes into account those comments?

Absolutely, thanks for taking the time to review this.



More information about the buildroot mailing list