[Buildroot] [PATCH] fs: add missing $$(sep) to pre- and post-command hooks code

Andrey Smirnov andrew.smirnov at gmail.com
Mon Nov 6 21:33:21 UTC 2017


On Fri, Nov 3, 2017 at 3:08 PM, Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
> Andrey, All,
>
> On 2017-11-03 11:49 -0700, Andrey Smirnov spake thusly:
>> When multiple hooks are registred, both pre-a and post-command hooks'
>> foreach loops need to have a separator at the end in order for the
>> code to work as intended. Without the separator all hooks end up as a
>> one single line command thus making all but the first hook into
>> no-ops.
>
> I had a hard time figuring out why they were ignored (and I was the one
> writing that). And it is pretty trivial: each hook is printed with
> PRINTF, which expands the hook in single quote, and there is no format
> string at all.
>
> So two hooks get expanded into (all on one line):
>     printf 'something expnded from first hook\n' print 'something else'
>
> and so on for the third and subsquent hooks. This should have been part
> of the commit message, I guess...
>
>> Fixes: 4628b6f3b4 ("fs: add pre- and post-command hooks")
>> Cc: Yann E. MORIN <yann.morin.1998 at free.fr>
>> Cc: Romain Naour <romain.naour at gmail.com>
>> Signed-off-by: Andrey Smirnov <andrew.smirnov at gmail.com>
>
> Acked-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
>
> Yet, could you explain the use-case where you need other such hooks?
>

Can't say I necessarily have a use-case for it, but I was
experimenting with overriding certain aspects of
skeleton-init-systemd's behavior using custom hooks and realized that
none of them were working. Hence this patch.

Thanks,
Andrey Smirnov



More information about the buildroot mailing list