[Buildroot] Bug in RPATH fixing logic

[Thomas Petazzoni]

Hello,

On Sun, 12 Nov 2017 20:35:39 +0100, Wolfgang Grandegger wrote:

> >> Well, the problem is that the binary gets processed twice in different
> >> directories because of the hard link, so if it instead was a softlink it
> >> woud get ignored by the RPATH logic and only get fixed up once - Right?  
> > 
> > Yes, soft links are ignored (only find -type f). $ORIGIN will not work 
> > with hard-linked binary files in different levels of the file hierarchy.   
> 
> Well, adding a proper $ORIGIN/... for each link to the RPATH would work 
> but detecting if other hard links exist is a bit tricky and would take 
> time. If the references count (number of hardlinks to a particular 
> inode) is greater than 1, we could process them in a special way. Not 
> sure if it's worth the effort.

Well, we're not at the point of deciding if it is worth the effort or
not: we have a bug, and we need to fix it somehow :)

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com