[Buildroot] [PATCH 1/1] qt5cinex: depends also on qt5quickcontrols

[Baruch Siach]

Hi Giulio,

On Tue, Nov 14, 2017 at 05:32:26PM +0100, Giulio Benetti wrote:
> Errata:
> 
> Il 14/11/2017 17:30, Giulio Benetti ha scritto:
> > qt5cinex failed to build if qt5quickcontrols is not selected
> qt5cinex fail to execute on runtime if qt5quickcontrols is not selected

If it's a runtime only dependency you should not list it in _DEPENDENCIES ...

> > add qt5quickcontrols to qt5cinex dependencies in .mk
> > select BR2_PACKAGE_QT5QUICKCONTROLS in Config.in
> > 
> > Signed-off-by: Giulio Benetti <giulio.benetti at micronovasrl.com>
> > ---
> >   package/qt5cinex/Config.in   | 1 +
> >   package/qt5cinex/qt5cinex.mk | 2 +-
> >   2 files changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/package/qt5cinex/Config.in b/package/qt5cinex/Config.in
> > index 5adf6c3..7cc459a 100644
> > --- a/package/qt5cinex/Config.in
> > +++ b/package/qt5cinex/Config.in
> > @@ -16,6 +16,7 @@ config BR2_PACKAGE_QT5CINEX
> >   	select BR2_PACKAGE_QT5BASE_WIDGETS
> >   	select BR2_PACKAGE_QT5BASE_EGLFS
> >   	select BR2_PACKAGE_QT5GRAPHICALEFFECTS
> > +	select BR2_PACKAGE_QT5QUICKCONTROLS

... but you should add a 'runtime' comment here.

> >   	help
> >   	  This application demonstrates the power of Qt5 and few of the new
> >   	  additions available in QtQuick 2.0.
> > diff --git a/package/qt5cinex/qt5cinex.mk b/package/qt5cinex/qt5cinex.mk
> > index d9254f5..44c53a1 100644
> > --- a/package/qt5cinex/qt5cinex.mk
> > +++ b/package/qt5cinex/qt5cinex.mk
> > @@ -12,7 +12,7 @@ QT5CINEX_HD = "rpi_"
> >   endif
> >   QT5CINEX_SOURCE = Qt5_CinematicExperience_$(QT5CINEX_HD)$(QT5CINEX_VERSION).tgz
> > -QT5CINEX_DEPENDENCIES = qt5base qt5declarative
> > +QT5CINEX_DEPENDENCIES = qt5base qt5declarative qt5quickcontrols
> >   QT5CINEX_LICENSE = CC-BY-3.0
> >   QT5CINEX_LICENSE_FILES = README

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -