[Buildroot] [PATCH] rtl8723bu: new package

[Mylene JOSSERAND]

Hello,

Le Mon, 27 Nov 2017 09:08:11 +0100,
Thomas Petazzoni <thomas.petazzoni at free-electrons.com> a écrit :

> Hello,
> 
> On Sun, 26 Nov 2017 22:59:13 +0100, Mylène Josserand wrote:
> > Add RTL8723BU package to compile the Realtek RTL8723BU Wifi driver.
> > 
> > Signed-off-by: Mylène Josserand
> > <mylene.josserand at free-electrons.com>  
> 
> Thanks for this contribution!
> 
> >  package/Config.in                |  1 +
> >  package/rtl8723bu/Config.in      | 10 ++++++++++
> >  package/rtl8723bu/rtl8723bu.hash |  2 ++
> >  package/rtl8723bu/rtl8723bu.mk   | 25 +++++++++++++++++++++++++
> >  4 files changed, 38 insertions(+)  
> 
> Could you add yourself to the DEVELOPERS file for this package?

Sure, no problem.

> 
> > diff --git a/package/rtl8723bu/rtl8723bu.mk
> > b/package/rtl8723bu/rtl8723bu.mk new file mode 100644
> > index 0000000000..774caa02f9
> > --- /dev/null
> > +++ b/package/rtl8723bu/rtl8723bu.mk
> > @@ -0,0 +1,25 @@
> > +################################################################################
> > +#
> > +# rtl8723bu
> > +#
> > +################################################################################
> > +
> > +RTL8723BU_VERSION = b922079a090dcaad58179d478442ff97f18521c9
> > +RTL8723BU_SITE = $(call
> > github,lwfinger,rtl8723bu,$(RTL8723BU_VERSION)) +RTL8723BU_LICENSE
> > = GPL-2.0, proprietary (*.bin firmware blobs) +
> > +RTL8723BU_MODULE_MAKE_OPTS = \
> > +	KVER=$(LINUX_VERSION_PROBED) \
> > +	KSRC=$(LINUX_DIR)
> > +
> > +RTL8723BU_BINS = rtl8723b_fw.bin
> > +
> > +define RTL8723BU_INSTALL_FIRMWARE
> > +	$(foreach bin, $(RTL8723BU_BINS), \
> > +		$(INSTALL) -D -m 644 $(@D)/$(bin)
> > $(TARGET_DIR)/lib/firmware/rtlwifi/$(bin)
> > +	)  
> 
> The loop is not needed, since you have a single firmware file, so this
> can be simplified as:
> 
> 	$(INSTALL) -D -m 0644 $(@D)/rtl8723b_fw.bin
> $(TARGET_DIR)/lib/firmware/rtlwifi/rtl8723b_fw.bin
> 

Yep, thank you. While testing it, I installed different firmwares and
finally, I reduced the list to one element. I forgot to remove the
loop :)

> > +endef
> > +RTL8723BU_POST_INSTALL_TARGET_HOOKS += RTL8723BU_INSTALL_FIRMWARE  
> 
> I know the rtl8723bs package that you probably used as an example does
> this, but in fact there is no need to use a post install target hook
> here. You can just do:
> 
> define RTL8723BU_INSTALL_TARGET_CMDS
> 	$(INSTALL) -D ...
> endef

Okay. I will fix the RTL8723BS package too, so.

> 
> Could you fix those minor details, and submit an updated version?

Sure, thank you for the review!

Best regards,

-- 
Mylène Josserand, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com