[Buildroot] [PATCH] mtools: do not link to libbsd

Baruch Siach baruch at tkos.co.il
Tue Nov 28 12:03:27 UTC 2017


Hi Carlos,

On Tue, Nov 28, 2017 at 08:48:17AM -0200, Carlos Santos wrote:
> mtools is unneccessarily linked to libbsd if this library is found by
> the configuration script. The same may happen to host-mtools if some
> libbsd-devel package is installed on the host machine. Prevent this by
> forcing configure to ignore the existence o libbsd.
> 
> I stumbled on this when I built host-mtools and removed libbsd-devel to
> upgrade to Fedora 27, due to Bug 1504831*. The previously built
> host/bin/mtools started to fail due to the missing libbsd.x.y.so
> 
> * https://bugzilla.redhat.com/show_bug.cgi?id=1504831

This is a valid reason to remove the host-mtools dependency on libbsd ...

> Signed-off-by: Carlos Santos <casantos at datacom.ind.br>
> ---
>  package/mtools/mtools.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/mtools/mtools.mk b/package/mtools/mtools.mk
> index 5db548fad9..1a6218831e 100644
> --- a/package/mtools/mtools.mk
> +++ b/package/mtools/mtools.mk
> @@ -13,9 +13,13 @@ MTOOLS_CONF_OPTS = --without-x
>  # info documentation not needed
>  MTOOLS_CONF_ENV = \
>  	ac_cv_func_setpgrp_void=yes \
> +	ac_cv_lib_bsd_gethostbyname=no \
> +	ac_cv_lib_bsd_main=no \

... but why no add an optional dependency on libbds for the target mtools 
package? In case we build target libbsd anyway, having mtools use libbsd would 
presumably reduce the binary size of mtools somewhat, isn't it?

>  	ac_cv_path_INSTALL_INFO=
>  
>  HOST_MTOOLS_CONF_ENV = \
> +	ac_cv_lib_bsd_gethostbyname=no \
> +	ac_cv_lib_bsd_main=no \
>  	ac_cv_path_INSTALL_INFO=
>  
>  # link with iconv if enabled

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -



More information about the buildroot mailing list