[Buildroot] [PATCH] mtools: do not link to libbsd

Baruch Siach baruch at tkos.co.il
Tue Nov 28 12:52:26 UTC 2017


Hi Carlos,

On Tue, Nov 28, 2017 at 10:36:02AM -0200, Carlos Santos wrote:
> > From: "Baruch Siach" <baruch at tkos.co.il>
> > To: "Carlos Santos" <casantos at datacom.ind.br>
> > Cc: buildroot at buildroot.org
> > Sent: Tuesday, November 28, 2017 10:03:27 AM
> > Subject: Re: [Buildroot] [PATCH] mtools: do not link to libbsd
> 
> [...]
> >> diff --git a/package/mtools/mtools.mk b/package/mtools/mtools.mk
> >> index 5db548fad9..1a6218831e 100644
> >> --- a/package/mtools/mtools.mk
> >> +++ b/package/mtools/mtools.mk
> >> @@ -13,9 +13,13 @@ MTOOLS_CONF_OPTS = --without-x
> >>  # info documentation not needed
> >>  MTOOLS_CONF_ENV = \
> >>  	ac_cv_func_setpgrp_void=yes \
> >> +	ac_cv_lib_bsd_gethostbyname=no \
> >> +	ac_cv_lib_bsd_main=no \
> > 
> > ... but why no add an optional dependency on libbds for the target mtools
> > package? In case we build target libbsd anyway, having mtools use libbsd would
> > presumably reduce the binary size of mtools somewhat, isn't it?
> 
> From the configure script:
> 
>     # The functions gethostbyname, getservbyname, and inet_addr are
>     # in -lbsd on LynxOS 3.0.1/i386, according to Lars Hecking.
> 
> On Buildroot gethostbyname is provided by glibc/uClibc/musl.

So if I understand correctly, mtools unnecessarily adds libbsd in a DT_NEEDED 
filed of its dynamic section, but it does not actually use anything from 
libbsd under Linux. Is that correct?

If so, please add this explanation in the commit log.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -



More information about the buildroot mailing list