[Buildroot] [PATCH v5 1/3] board: Add Vyasa RK3288 board support

Baruch Siach baruch at tkos.co.il
Wed Nov 29 08:23:28 UTC 2017


Hi Thomas,

On Wed, Nov 29, 2017 at 08:53:34AM +0100, Thomas Petazzoni wrote:
> On Wed, 29 Nov 2017 12:21:24 +0530, Jagan Teki wrote:
> 
> > > As Thomas mentioned in his review for v4, no way to use linux-next git tree.
> > > It is being rebased all the time. So changing commit ID is not going to help:
> > > it will be changed over and over again.  
> > 
> > Thomas never said to use the linux-next, but instead he mentioned to
> > not use the last sha1 which always changed during rebase. So the sha1
> > I have used here specific to this board which shouldn't change even
> > linux-next rebased.
> 
> What you're saying here doesn't make sense.
> 
> Either the commit you're referring to is part of Linus tree (and
> therefore is stable and will never change), but in this case, there is
> no reason to use linux-next at all.
> 
> Or the commit you're referring to is not part of Linus tree, but is
> really on top of it, part of linux-next, and in this case, the commit
> is not stable and it will disappear every day, as linux-next is rebased
> every day.

I seems that linux-next preserves older next-[date] tags. It currently goes 
back to next-20170831. The linux-next-history.git tree carries even older 
tags, back to next-20160118. So a specific commit in linux-next{-history} 
should not disappear overnight.

I do agree, though, that having a board/platform specific git tree, or a set 
of patches is easier to work with.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -



More information about the buildroot mailing list