[Buildroot] [PATCH] support/run-tests: export download dir
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Tue Oct 10 21:33:47 UTC 2017
Hello,
On Sun, 17 Sep 2017 11:20:28 +0200, Yann E. MORIN wrote:
> Currently, the download directory, when specified with the -d option, is
> only used to store the files downloaded by the testing infra, not those
> downloaded by Buildroot.
>
> So, we end up with this situation:
>
> BR2_DL_DIR | -d DIR | test downloads | BR downloads
> ------------+----------+------------------+--------------
> unset | unset | [error] | [error]
> unset | set | in $(DIR) | in $(TOP_DIR)/dl
> set | unset | in $(BR2_DL_DIR) | in $(BR2_DL_DIR)
> set | set | in $(DIR) | in $(BR2_DL_DIR)
>
> This is not very consistent.
>
> We change the behaviour so that the value of -d always takes precedence,
> and is used by Buildroot as well, giving this new behaviour:
>
> BR2_DL_DIR | -d DIR | test downloads | BR downloads
> ------------+----------+------------------+--------------
> unset | unset | [error] | [error]
> unset | set | in $(DIR) | in $(DIR)
> set | unset | in $(BR2_DL_DIR) | in $(BR2_DL_DIR)
> set | set | in $(DIR) | in $(DIR)
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Cc: Ricardo Martincoski <ricardo.martincoski at gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> ---
> support/testing/run-tests | 1 +
> 1 file changed, 1 insertion(+)
Indeed, makes sense. Applied, thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list