[Buildroot] [PATCH] swig: enable support for Node.js >= 7.x

Yegor Yefremov yegorslists at googlemail.com
Sun Oct 8 17:16:11 UTC 2017


Hi Thomas,

On Sun, Oct 8, 2017 at 3:52 PM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Hello,
>
> On Fri, 29 Sep 2017 13:59:16 +0200, yegorslists at googlemail.com wrote:
>> From: Yegor Yefremov <yegorslists at googlemail.com>
>>
>> Recent Node.js versions have removed some depreciated API calls,
>> that swig still relies on. Patches taken from this PR [1] fix
>> this issue.
>>
>> [1] https://github.com/swig/swig/pull/968
>>
>> Signed-off-by: Yegor Yefremov <yegorslists at googlemail.com>
>> ---
>>  .../0001-Add-Node-7.x-aka-V8-5.2-support.patch     | 328 +++++++++++++++++++++
>>  ...e-warnings-on-Node-6.x-aka-V8-5.0-and-5.1.patch | 222 ++++++++++++++
>
> Applied to master.
>
> To be honest, I hesitated a bit, those patches are a bit big and
> invasive, and have not been merged upstream yet. I've merged anyway,
> but we might need to drop them at the next swig bump if they haven't
> been merged upstream.

Thanks for merging. The problem is that the project lacks a Node.js
maintainer. That's why none has applied the patch.

> Also, how do you in practice build swig with nodejs support? There is
> no dependency between host-swig and host-nodejs.

SWIG as such has nothing to do with Node.js directly, but it creates
code, that will be compiled against node.js via node-gyp utility [1].
BR uses newest Node.js version with removed obsolete APIs. That's why
we need this patch, but SWIG has no direct dependency to host-nodejs.

[1] https://github.com/nodejs/node-gyp

Yegor



More information about the buildroot mailing list