[Buildroot] [PATCH] parted: properly link with libiconv

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Oct 8 21:09:25 UTC 2017


Hello,

On Sun, 8 Oct 2017 01:06:11 +0200, Arnout Vandecappelle
(Essensium/Mind) wrote:
> parted uses libiconv but doesn't link with it. All the checks are there
> in configure, but the Makefile.am doesn't add it to the link. Add a
> patch to fix this.
> 
> Also add an optional dependency on libiconv, so it is reproducible.
> 
> While we're at it, regenerate the existing patches on top of v3.2, and
> make patch 0003 a properly git formatted one.
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
> Cc: srg.venema at gmail.com

This seems to do more harm than good: it now tries to link with -liconv
in all cases, even when it is not needed (for example with glibc).

  http://autobuild.buildroot.net/?reason=parted-3.2

I've reverted your patch for now.

Best regards,

Thomas Petazzoni
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com



More information about the buildroot mailing list