[Buildroot] [PATCH 1/1] libcpprestsdk: new package

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Oct 17 19:57:23 UTC 2017


Hello,

On Tue, 17 Oct 2017 15:22:57 -0400, Adam Duskett wrote:
> diff --git a/package/libcpprestsdk/Config.in b/package/libcpprestsdk/Config.in
> new file mode 100644
> index 0000000000..d6acabea8a
> --- /dev/null
> +++ b/package/libcpprestsdk/Config.in
> @@ -0,0 +1,22 @@
> +config BR2_PACKAGE_LIBCPPRESTSDK
> +	bool "libcpprestsdk"
> +	depends on BR2_INSTALL_LIBSTDCPP # boost
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	select BR2_PACKAGE_BOOST

Boost depends on BR2_USE_WCHAR, you forgot to propagate this
dependency.

> +	select BR2_PACKAGE_BOOST_RANDOM
> +	select BR2_PACKAGE_BOOST_CHRONO
> +	select BR2_PACKAGE_BOOST_THREAD
> +	select BR2_PACKAGE_BOOST_REGEX
> +	select BR2_PACKAGE_BOOST_FILESYSTEM
> +	select BR2_PACKAGE_OPENSSL if !BR2_PACKAGE_LIBRESSL
> +	help
> +	  The C++ REST SDK is a Microsoft project for cloud-based
> +	  client-server communication in native code using a modern
> +	  asynchronous C++ API design. This project aims to help C++
> +	  developers connect to and interact with services.
> +
> +	  https://github.com/Microsoft/cpprestsdk
> +
> +comment "cpprestsdk needs a toolchain w/ C++, threads"
> +	depends on BR2_USE_MMU

Why do you have this BR2_USE_MMU dependency here, when it's not on the
main BR2_PACKAGE_LIBCPPRESTSDK option ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com



More information about the buildroot mailing list