[Buildroot] [PATCH] powertop: needs autoreconf

Baruch Siach baruch at tkos.co.il
Wed Oct 18 19:33:39 UTC 2017


Hi Romain,

On Wed, Oct 18, 2017 at 08:58:55PM +0200, Romain Naour wrote:
> Le 18/10/2017 à 20:03, Baruch Siach a écrit :
> > Commit 01048deab60 (package/powertop: bump to version 2.9) removed
> > autoreconf even though the remaining patch touches Makefile.am. Fix
> > this.
> 
> Indeed...
> I don't recall what happened, probably I had the intend to remove all patches
> with the version bump but I finally re-added
> 0001-dont-force-stack-smashing-protection.patch.
> 
> The issue appear now following the automake bump 1.15.1.
> 
> > Fixes:
> > http://autobuild.buildroot.net/results/3bf/3bf8daee559e2978f8602c56397afda771299032/
> > http://autobuild.buildroot.net/results/f9b/f9b4f113a333107a972fa51bd0347eeb0d52496f/
> > http://autobuild.buildroot.net/results/067/0675826888b6f89e76291c7835839344300ca9f5/
> > 
> > Cc: Romain Naour <romain.naour at gmail.com>
> > Cc: Steven Noonan <steven at uplinklabs.net>
> > Signed-off-by: Baruch Siach <baruch at tkos.co.il>
> > ---
> >  package/powertop/powertop.mk | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/package/powertop/powertop.mk b/package/powertop/powertop.mk
> > index ce7a11875894..7c9c7ccc3f41 100644
> > --- a/package/powertop/powertop.mk
> > +++ b/package/powertop/powertop.mk
> > @@ -12,6 +12,8 @@ POWERTOP_DEPENDENCIES = pciutils ncurses libnl host-pkgconf \
> >  POWERTOP_LICENSE = GPL-2.0
> >  POWERTOP_LICENSE_FILES = COPYING
> >  POWERTOP_CONF_ENV = LIBS=$(TARGET_NLS_LIBS)
> > +# Patching Makefile.am
> 
> Maybe you can name the patch here
> # 0001-dont-force-stack-smashing-protection.patch
> 
> > +POWERTOP_AUTORECONF = YES
> 
> Gettextize was needed with powertop 2.27, can you check if it's still needed ?

The build succeeds here without gettextize. The same config fails without the 
patch with the same error as the autobuilder.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -



More information about the buildroot mailing list