[Buildroot] [PATCH v2 1/2] package/libssh2: Add selectable crypto libraries

[Baruch Siach]

Hi Sam,

On Mon, Oct 30, 2017 at 09:27:17AM -0500, Sam Voss wrote:
> On Mon, Oct 30, 2017 at 12:19 AM, Baruch Siach <baruch at tkos.co.il> wrote:
> [...]
> > Have you tested combination of options after the version bump in the next
> > patch?
> 
> Could you elaborate on this? I don't understand what you mean by
> combination of options.

When you have for example both openssl and mbedtls enabled, the 
--with-[backend] options will no longer work after the version bump. So the 
crypto backend selection logic will have no effect, so you might end up with 
the wrong backend being used.

When testing these patches try enabling multiple crypto packages, and make 
sure that only the backend you selected for libssh2 is the one that is 
actually used.

> > The master libssh2 branch changes the configure crypto selection options to
> > --with-crypto=auto|openssl|libgcrypt|mbedtls. You should either take this into
> > account in the version bump patch, or (preferably, IMO) reverse the patches
> > order, change to --with-crypto in the version bump patch, and add selectable
> > crypto backend in the second.
> 
> Good catch, I didn't catch this in the diffs. I will look into these options.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -