[Buildroot] [PATCH v2 1/1] gstreamer1-mm: new package
Adam Duskett
aduskett at gmail.com
Mon Sep 25 15:01:12 UTC 2017
Gstreamermm provides C++ bindings for gstreamer.
Signed-off-by: Adam Duskett <aduskett at gmail.com>
---
Changes v1 -> v2:
- Changed the name of the package from gst1-mm to gstreamer1-mm (Arnout)
- Added upstream author information to the patches (Arnout)
- Changed the upstream repo from github to git.gnome.org (Arnout)
- Added myself to the DEVELOPERS file.
- Added --enable-unittests=no to the mk file, as the default is auto.
DEVELOPERS | 1 +
package/gstreamer1/Config.in | 1 +
...ock-auto-generate-some-audioclock-methods.patch | 68 +++++++
.../gstreamer1-mm/0002-fix-iterator-build.patch | 207 +++++++++++++++++++++
.../0003-remove-gstreamer-check-dependency.patch | 29 +++
package/gstreamer1/gstreamer1-mm/Config.in | 18 ++
.../gstreamer1/gstreamer1-mm/gstreamer1-mm.hash | 2 +
package/gstreamer1/gstreamer1-mm/gstreamer1-mm.mk | 24 +++
8 files changed, 350 insertions(+)
create mode 100644 package/gstreamer1/gstreamer1-mm/0001-gst-audioclock-auto-generate-some-audioclock-methods.patch
create mode 100644 package/gstreamer1/gstreamer1-mm/0002-fix-iterator-build.patch
create mode 100644 package/gstreamer1/gstreamer1-mm/0003-remove-gstreamer-check-dependency.patch
create mode 100644 package/gstreamer1/gstreamer1-mm/Config.in
create mode 100644 package/gstreamer1/gstreamer1-mm/gstreamer1-mm.hash
create mode 100644 package/gstreamer1/gstreamer1-mm/gstreamer1-mm.mk
diff --git a/DEVELOPERS b/DEVELOPERS
index e34802f2ba..0342b1cc41 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -32,6 +32,7 @@ F: package/gstreamer1/gst1-rtsp-server/
N: Adam Duskett <aduskett at gmail.com>
F: package/audit/
F: package/checkpolicy/
+F: package/gstreamer1/gstreamer1-mm/
F: package/gstreamer1/gst1-vaapi/
F: package/janus-gateway/
F: package/libressl/
diff --git a/package/gstreamer1/Config.in b/package/gstreamer1/Config.in
index aef75b55bf..a7b2a70d5b 100644
--- a/package/gstreamer1/Config.in
+++ b/package/gstreamer1/Config.in
@@ -12,4 +12,5 @@ source "package/gstreamer1/gst1-rtsp-server/Config.in"
source "package/gstreamer1/gst1-validate/Config.in"
source "package/gstreamer1/gst1-vaapi/Config.in"
source "package/gstreamer1/gst-omx/Config.in"
+source "package/gstreamer1/gstreamer1-mm/Config.in"
endif
diff --git a/package/gstreamer1/gstreamer1-mm/0001-gst-audioclock-auto-generate-some-audioclock-methods.patch b/package/gstreamer1/gstreamer1-mm/0001-gst-audioclock-auto-generate-some-audioclock-methods.patch
new file mode 100644
index 0000000000..6f35a62cee
--- /dev/null
+++ b/package/gstreamer1/gstreamer1-mm/0001-gst-audioclock-auto-generate-some-audioclock-methods.patch
@@ -0,0 +1,68 @@
+From 33d5ab0b12ee26823be155f766a4becdf1711b7c Mon Sep 17 00:00:00 2001
+From: Marcin Kolny <marcin.kolny at gmail.com>
+Date: Sat, 10 Jun 2017 15:11:22 +0100
+Subject: [PATCH] Gst::AudioClock: auto generate some audioclock methods
+
+Those methods used to have object of GstClock type as a
+first argument, so had to be wrapped manually. It has been
+fixed inGStreamer (https://bugzilla.gnome.org/show_bug.cgi?id=756628)
+in version 1.12.0
+
+https://bugzilla.gnome.org/show_bug.cgi?id=783628
+Signed-off-by: Adam Duskett <aduskett at gmail.com>
+[Upstream commit: https://git.gnome.org/browse/gstreamermm/commit/?id=167eeba7757027e5faf8cdb59030ca094af04763]
+---
+ gstreamer/gstreamermm/audioclock.cc | 30 +++++++++++++++---------------
+ 1 file changed, 15 insertions(+), 15 deletions(-)
+
+diff --git a/gstreamer/gstreamermm/audioclock.cc b/gstreamer/gstreamermm/audioclock.cc
+index 0bd4bc4..a2b18c4 100644
+--- a/gstreamer/gstreamermm/audioclock.cc
++++ b/gstreamer/gstreamermm/audioclock.cc
+@@ -74,21 +74,6 @@ AudioClock::AudioClock(const Glib::ustring& name, const SlotGetTime& time_slot)
+ gobj()->user_data = m_slot.get();
+ }
+
+-Gst::ClockTime AudioClock::adjust(Gst::ClockTime time)
+-{
+- return static_cast<Gst::ClockTime>(gst_audio_clock_adjust(GST_CLOCK_CAST(gobj()), static_cast<GstClockTime>(time)));
+-}
+-
+-Gst::ClockTime AudioClock::get_time() const
+-{
+- return static_cast<Gst::ClockTime>(gst_audio_clock_get_time(GST_CLOCK_CAST(gobj())));
+-}
+-
+-void AudioClock::invalidate()
+-{
+- gst_audio_clock_invalidate(GST_CLOCK_CAST(gobj()));
+-}
+-
+ } //namespace Gst
+
+ namespace
+@@ -211,6 +196,21 @@ void AudioClock::reset(Gst::ClockTime time)
+ gst_audio_clock_reset(gobj(), ((GstClockTime)(time)));
+ }
+
++Gst::ClockTime AudioClock::adjust(Gst::ClockTime time)
++{
++ return ((Gst::ClockTime)(gst_audio_clock_adjust(gobj(), ((GstClockTime)(time)))));
++}
++
++Gst::ClockTime AudioClock::get_time() const
++{
++ return ((Gst::ClockTime)(gst_audio_clock_get_time(const_cast<GstAudioClock*>(gobj()))));
++}
++
++void AudioClock::invalidate()
++{
++ gst_audio_clock_invalidate(gobj());
++}
++
+
+ } // namespace Gst
+
+--
+2.13.5
+
diff --git a/package/gstreamer1/gstreamer1-mm/0002-fix-iterator-build.patch b/package/gstreamer1/gstreamer1-mm/0002-fix-iterator-build.patch
new file mode 100644
index 0000000000..75b5280265
--- /dev/null
+++ b/package/gstreamer1/gstreamer1-mm/0002-fix-iterator-build.patch
@@ -0,0 +1,207 @@
+From 70a44a8e489f08bddaa180016837d00f420f9e99 Mon Sep 17 00:00:00 2001
+From: Marcin Kolny <marcin.kolny at gmail.com>
+Date: Sun, 2 Jul 2017 13:48:29 +0100
+Subject: [PATCH] Gst::Iterator: fix iterator build
+
+https://bugzilla.gnome.org/show_bug.cgi?id=783678
+Signed-off-by: Adam Duskett <aduskett at gmail.com>
+[Upstream commit: https://git.gnome.org/browse/gstreamermm/commit/?id=2a195b23bda7fef980a2dd00aedd9f1decab7a89]
+---
+ gstreamer/src/iterator.hg | 63 +++++++++++++++++++++++------------------------
+ tests/Makefile.am | 2 ++
+ tests/test-iterator.cc | 62 ++++++++++++++++++++++++++++++++++++++++++++++
+ 3 files changed, 95 insertions(+), 32 deletions(-)
+ create mode 100644 tests/test-iterator.cc
+
+diff --git a/gstreamer/src/iterator.hg b/gstreamer/src/iterator.hg
+index 6f10417..f76c34d 100644
+--- a/gstreamer/src/iterator.hg
++++ b/gstreamer/src/iterator.hg
+@@ -125,9 +125,6 @@ private:
+ GstIterator* cobject_; // The underlying C object.
+ bool take_ownership; // Whether to destroy C object with the wrapper.
+ #endif /* DOXYGEN_SHOULD_SKIP_THIS */
+-
+-private:
+- void swap(IteratorBase<CppType>& other);
+ };
+
+ /** A class used to retrieve multiple elements in a thread safe way.
+@@ -243,18 +240,25 @@ template<class CppType>
+ IteratorBase<CppType>::IteratorBase()
+ : current(G_VALUE_INIT),
+ current_result(Gst::ITERATOR_OK),
+- cobject_(0),
++ cobject_(nullptr),
+ take_ownership(true)
+ {
+ }
+
+ template<class CppType>
+ IteratorBase<CppType>::IteratorBase(const IteratorBase<CppType>& other)
+- : current(other.current),
++ : current(G_VALUE_INIT),
+ current_result(other.current_result),
+- cobject_(const_cast<GstIterator*>(other.cobj())),
+- take_ownership((other.cobj()) ? false : true)
+-{}
++ take_ownership(other.take_ownership)
++{
++ cobject_ = other.take_ownership ? gst_iterator_copy(other.cobject_) : other.cobject_;
++
++ if (G_IS_VALUE (&other.current))
++ {
++ g_value_init(¤t, G_VALUE_TYPE(&other.current));
++ g_value_copy(&other.current, ¤t);
++ }
++}
+
+ template<class CppType>
+ IteratorBase<CppType>::IteratorBase(GstIterator* castitem, bool take_ownership)
+@@ -267,8 +271,25 @@ IteratorBase<CppType>::IteratorBase(GstIterator* castitem, bool take_ownership)
+ template<class CppType>
+ IteratorBase<CppType>& IteratorBase<CppType>::operator=(const IteratorBase<CppType>& other)
+ {
+- IteratorBase temp(other);
+- swap(temp);
++ if (cobject_ && take_ownership)
++ {
++ gst_iterator_free(cobject_);
++ }
++
++ if (G_IS_VALUE(¤t))
++ {
++ g_value_unset(¤t);
++ }
++
++ current_result = other.current_result;
++ cobject_ = other.take_ownership ? gst_iterator_copy(other.cobject_) : other.cobject_;
++
++ if (G_IS_VALUE (&other.current))
++ {
++ g_value_init(¤t, G_VALUE_TYPE(&other.current));
++ g_value_copy(&other.current, ¤t);
++ }
++
+ return *this;
+ }
+
+@@ -315,28 +336,6 @@ IteratorBase<CppType>::operator bool() const
+ return (! G_VALUE_HOLDS_OBJECT(¤t));
+ }
+
+-template<class CppType>
+-void IteratorBase<CppType>::swap(IteratorBase<CppType>& other)
+-{
+- GstIterator *const temp_obj = cobject_;
+- cobject_ = other.cobject_;
+- other.cobject_ = temp_obj;
+-
+- const bool temp_take_ownership = take_ownership;
+- take_ownership = other.take_ownership;
+- other.take_ownership = temp_take_ownership;
+-
+- GValue temp_current = G_VALUE_INIT;
+- g_value_init(&temp_current, G_VALUE_TYPE(current));
+- g_value_copy(¤t, &temp_current);
+- g_value_copy(other.current, ¤t);
+- g_value_copy(&temp_current, other.current);
+-
+- const IteratorResult temp_result = current_result;
+- current_result = other.current_result;
+- other.current_result = temp_result;
+-}
+-
+ //virtual
+ template<class CppType>
+ IteratorBase<CppType>::~IteratorBase()
+diff --git a/tests/Makefile.am b/tests/Makefile.am
+index c734b62..1d931a9 100644
+--- a/tests/Makefile.am
++++ b/tests/Makefile.am
+@@ -31,6 +31,7 @@ check_PROGRAMS = \
+ test-element \
+ test-ghostpad \
+ test-init \
++ test-iterator \
+ test-memory \
+ test-message \
+ test-miniobject \
+@@ -74,6 +75,7 @@ test_caps_SOURCES = $(TEST_GTEST_SOURCES) test-cap
+ test_element_SOURCES = $(TEST_GTEST_SOURCES) test-element.cc
+ test_ghostpad_SOURCES = $(TEST_GTEST_SOURCES) test-ghostpad.cc
+ test_init_SOURCES = $(TEST_GTEST_SOURCES) test-init.cc
++test_iterator_SOURCES = $(TEST_GTEST_SOURCES) test-iterator.cc
+ test_memory_SOURCES = $(TEST_GTEST_SOURCES) test-memory.cc
+ test_message_SOURCES = $(TEST_GTEST_SOURCES) test-message.cc
+ test_miniobject_SOURCES = $(TEST_GTEST_SOURCES) test-miniobject.cc
+diff --git a/tests/test-iterator.cc b/tests/test-iterator.cc
+new file mode 100644
+index 0000000..0a90a5b
+--- /dev/null
++++ b/tests/test-iterator.cc
+@@ -0,0 +1,62 @@
++#include "mmtest.h"
++#include <gstreamermm.h>
++
++using namespace Gst;
++using Glib::RefPtr;
++
++TEST(IteratorTest, AssignmentOperatorShouldCopyIterator)
++{
++ Glib::RefPtr<Gst::Element> element = Gst::ElementFactory::create_element("fakesink");
++
++ Gst::Iterator<Gst::Pad> iter = element->iterate_pads();
++ Gst::Iterator<Gst::Pad> iter2;
++ iter2 = iter;
++
++ while (iter.next())
++ {
++ ASSERT_STREQ("sink", iter->get_name().c_str());
++ }
++
++ while(iter2.next())
++ {
++ ASSERT_STREQ("sink", iter2->get_name().c_str());
++ }
++}
++
++
++TEST(IteratorTest, BeginShouldResetIterator)
++{
++ Glib::RefPtr<Gst::Element> element = Gst::ElementFactory::create_element("fakesink");
++
++ Gst::Iterator<Gst::Pad> iter = element->iterate_pads();
++
++ while (iter.next())
++ {
++ ASSERT_STREQ("sink", iter->get_name().c_str());
++ }
++
++ iter.begin();
++ while (iter.next())
++ {
++ ASSERT_STREQ("sink", iter->get_name().c_str());
++ }
++}
++
++TEST(IteratorTest, CopyConstructorShouldCopyIteratorAndItsState)
++{
++ Glib::RefPtr<Gst::Element> element = Gst::ElementFactory::create_element("fakesink");
++
++ Gst::Iterator<Gst::Pad> iter = element->iterate_pads();
++
++ while (iter.next())
++ {
++ ASSERT_STREQ("sink", iter->get_name().c_str());
++ }
++
++ ASSERT_FALSE(iter.next());
++
++ Gst::Iterator<Gst::Pad> iter2 = iter;
++
++ ASSERT_FALSE(iter.next());
++}
++
+--
+2.13.5
diff --git a/package/gstreamer1/gstreamer1-mm/0003-remove-gstreamer-check-dependency.patch b/package/gstreamer1/gstreamer1-mm/0003-remove-gstreamer-check-dependency.patch
new file mode 100644
index 0000000000..70a05a6cdb
--- /dev/null
+++ b/package/gstreamer1/gstreamer1-mm/0003-remove-gstreamer-check-dependency.patch
@@ -0,0 +1,29 @@
+From f65960a21c76bcd1371a9d0d3b008731d02a0e5d Mon Sep 17 00:00:00 2001
+From: Adam Duskett <aduskett at gmail.com>
+Date: Thu, 31 Aug 2017 11:42:40 -0400
+Subject: [PATCH] remove gstreamer-check dependency
+
+gstreamer-check is disabled by default in buildroot and itsn't required to
+build gstreamermm. Remove the requirement from configure.
+
+Signed-off-by: Adam Duskett <aduskett at gmail.com>
+---
+ configure | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/configure b/configure
+index de43442..c30bc4c 100755
+--- a/configure
++++ b/configure
+@@ -16685,7 +16685,7 @@ fi
+ # The format below is used so that the requirements appear nicely in the .pc
+ # file.
+
+-GSTREAMERMM_MODULES='giomm-2.4 >= 2.47.6 gstreamer-1.0 >= 1.8.0 gstreamer-base-1.0 >= 1.8.0 gstreamer-check-1.0 >= 1.8.0 gstreamer-controller-1.0 >= 1.8.0 gstreamer-net-1.0 >= 1.8.0 gstreamer-allocators-1.0 >= 1.8.0 gstreamer-app-1.0 >= 1.8.0 gstreamer-audio-1.0 >= 1.8.0 gstreamer-fft-1.0 >= 1.8.0 gstreamer-pbutils-1.0 >= 1.8.0 gstreamer-plugins-base-1.0 >= 1.8.0 gstreamer-riff-1.0 >= 1.8.0 gstreamer-rtp-1.0 >= 1.8.0 gstreamer-rtsp-1.0 >= 1.8.0 gstreamer-sdp-1.0 >= 1.8.0 gstreamer-tag-1.0 >= 1.8.0 gstreamer-video-1.0 >= 1.8.0'
++GSTREAMERMM_MODULES='giomm-2.4 >= 2.47.6 gstreamer-1.0 >= 1.8.0 gstreamer-base-1.0 >= 1.8.0 gstreamer-controller-1.0 >= 1.8.0 gstreamer-net-1.0 >= 1.8.0 gstreamer-allocators-1.0 >= 1.8.0 gstreamer-app-1.0 >= 1.8.0 gstreamer-audio-1.0 >= 1.8.0 gstreamer-fft-1.0 >= 1.8.0 gstreamer-pbutils-1.0 >= 1.8.0 gstreamer-plugins-base-1.0 >= 1.8.0 gstreamer-riff-1.0 >= 1.8.0 gstreamer-rtp-1.0 >= 1.8.0 gstreamer-rtsp-1.0 >= 1.8.0 gstreamer-sdp-1.0 >= 1.8.0 gstreamer-tag-1.0 >= 1.8.0 gstreamer-video-1.0 >= 1.8.0'
+
+
+
+--
+2.13.5
+
diff --git a/package/gstreamer1/gstreamer1-mm/Config.in b/package/gstreamer1/gstreamer1-mm/Config.in
new file mode 100644
index 0000000000..a2915547ea
--- /dev/null
+++ b/package/gstreamer1/gstreamer1-mm/Config.in
@@ -0,0 +1,18 @@
+config BR2_PACKAGE_GSTREAMER1_MM
+ bool "Gstreamer C++ bindings"
+ select BR2_PACKAGE_GST1_PLUGINS_BASE
+ select BR2_PACKAGE_GLIBMM
+ help
+ gstreamermm provides C++ bindings for the GStreamer streaming
+ multimedia library (http://gstreamer.freedesktop.org). With
+ gstreamermm it is possible to develop applications that work
+ with multimedia in C++.
+
+ gstreamermm is developed over glibmm, libsigc++ and libxml++
+ and the functionalities they provide. This means that, among
+ other things, referencing and unreferencing of GObjects is
+ handled automatically via glibmm's automatic pointer class,
+ Glib::RefPtr, and libsigc++'s slots are used for callbacks and
+ signals.
+
+ https://gstreamer.freedesktop.org/bindings/cplusplus.html
diff --git a/package/gstreamer1/gstreamer1-mm/gstreamer1-mm.hash b/package/gstreamer1/gstreamer1-mm/gstreamer1-mm.hash
new file mode 100644
index 0000000000..d10e002151
--- /dev/null
+++ b/package/gstreamer1/gstreamer1-mm/gstreamer1-mm.hash
@@ -0,0 +1,2 @@
+#From http://ftp.gnome.org/pub/gnome/sources/gstreamermm/1.8/gstreamermm-1.8.0.sha256sum
+sha256 3ee3c1457ea2c32c1e17b784faa828f414ba27a9731532bf26d137a2ad999a44 gstreamermm-1.8.0.tar.xz
diff --git a/package/gstreamer1/gstreamer1-mm/gstreamer1-mm.mk b/package/gstreamer1/gstreamer1-mm/gstreamer1-mm.mk
new file mode 100644
index 0000000000..9bc4669ef1
--- /dev/null
+++ b/package/gstreamer1/gstreamer1-mm/gstreamer1-mm.mk
@@ -0,0 +1,24 @@
+################################################################################
+#
+# gstreamer1-mm
+#
+################################################################################
+
+GSTREAMER1_MM_VERSION_MAJOR = 1.8
+GSTREAMER1_MM_VERSION = $(GSTREAMER1_MM_VERSION_MAJOR).0
+GSTREAMER1_MM_SITE = http://ftp.gnome.org/pub/gnome/sources/gstreamermm/$(GSTREAMER1_MM_VERSION_MAJOR)
+GSTREAMER1_MM_SOURCE = gstreamermm-$(GSTREAMER1_MM_VERSION).tar.xz
+GSTREAMER1_MM_LICENSE = LGPL-2.1+
+GSTREAMER1_MM_LICENSE_FILES = COPYING.LIB
+GSTREAMER1_MM_INSTALL_STAGING = YES
+GSTREAMER1_MM_DEPENDENCIES += \
+ glibmm \
+ gstreamer1 \
+ gst1-plugins-base
+
+GSTREAMER1_MM_CONF_OPTS += \
+ --disable-gl \
+ --disable-plugins-bad \
+ --enable-unittests=no
+
+$(eval $(autotools-package))
--
2.13.5
More information about the buildroot
mailing list