[Buildroot] [PATCH v4 04/11] package/mesa3d: enable llvm support

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sun Apr 1 20:53:02 UTC 2018


Hello,

On Thu, 29 Mar 2018 13:33:39 +0200, Valentin Korenblit wrote:

> +config BR2_PACKAGE_MESA3D_LLVM
> +	bool "mesa3d w/ llvm"

We're already under the mesa3d option, so repeating mesa3d in the
prompt is not useless. Just "llvm support" is enough.

Should the option be: bool "llvmpipe" ? Or is LLVM used by mesa3d for
something else ?

> +	depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS
> +	select BR2_PACKAGE_LLVM
> +
> +comment "mesa3d w/ llvm needs llvm"
> +	depends on !BR2_PACKAGE_LLVM_ARCH_SUPPORTS

This comment doesn't make sense: BR2_PACKAGE_LLVM_ARCH_SUPPORTS is an
architecture limitation, and therefore that the user can do about it.
Just drop this comment.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list