[Buildroot] [PATCH v2 18/37] docs/manual: add check-package to "Tips and tricks"
Ricardo Martincoski
ricardo.martincoski at gmail.com
Sun Apr 1 05:08:31 UTC 2018
And add two references to it: in "Submitting patches" and in "Adding new
packages to Buildroot" sections.
Signed-off-by: Ricardo Martincoski <ricardo.martincoski at gmail.com>
Cc: Thomas De Schampheleire <thomas.de_schampheleire at nokia.com>
---
Changes v1 -> v2:
- no changes
---
docs/manual/adding-packages-tips.txt | 31 +++++++++++++++++++++++++++++++
docs/manual/adding-packages.txt | 2 ++
docs/manual/contribute.txt | 4 ++++
3 files changed, 37 insertions(+)
diff --git a/docs/manual/adding-packages-tips.txt b/docs/manual/adding-packages-tips.txt
index 19577fa821..b13a7bef80 100644
--- a/docs/manual/adding-packages-tips.txt
+++ b/docs/manual/adding-packages-tips.txt
@@ -32,6 +32,37 @@ using the following rules:
with `.` and `-` characters substituted with `_` (e.g.:
+FOO_BAR_BOO_VERSION+).
+[[check-package]]
+==== How to check the coding style
+
+Buildroot provides a script in +utils/check-package+ that checks new or
+changed files for coding style. It is not a complete language validator,
+but it catches many common mistakes. It is meant to run in the actual
+files you created or modified, before creating the patch for submission.
+
+This script can be used for packages and also for package-like files:
+boot, fs, toolchain, ... ; but it does not check package infra types.
+
+To use it, run the +check-package+ script, by telling which files you
+created or changed:
+
+----
+$ ./utils/check-package package/new-package/*
+----
+
+If you have the +utils+ directory in your path you can also run:
+
+----
+$ cd package/new-package/
+$ check-package *
+----
+
+The tool can also be used for proprietary packages in a br2-external:
+
+----
+$ check-package -b /path/to/br2-ext-tree/package/my-package/*
+----
+
[[testing-package]]
==== How to test your package
diff --git a/docs/manual/adding-packages.txt b/docs/manual/adding-packages.txt
index c642146287..76fca6bf8c 100644
--- a/docs/manual/adding-packages.txt
+++ b/docs/manual/adding-packages.txt
@@ -12,6 +12,8 @@ tuning their configuration.
When you add a new package, be sure to test it in various conditions;
see xref:testing-package[]
+Also check the new package for coding style; see xref:check-package[]
+
include::adding-packages-directory.txt[]
include::adding-packages-generic.txt[]
diff --git a/docs/manual/contribute.txt b/docs/manual/contribute.txt
index 8bbc2b9eb7..b531ea987e 100644
--- a/docs/manual/contribute.txt
+++ b/docs/manual/contribute.txt
@@ -264,6 +264,10 @@ yourself to the DEVELOPERS file. This should be done in the same patch
creating or modifying the package. See xref:DEVELOPERS[the DEVELOPERS file]
for more information.
+Buildroot provides a handy tool to check for common coding style
+mistakes on files you created or modified, called +check-package+ (see
+xref:check-package[] for more information).
+
==== Preparing a patch series
Starting from the changes committed in your local git view, _rebase_
--
2.14.1
More information about the buildroot
mailing list