[Buildroot] [PATCH v4 04/11] package/mesa3d: enable llvm support

[Valentin Korenblit]

Hello Thomas,

On 01/04/2018 22:53, Thomas Petazzoni wrote:
> Hello,
>
> On Thu, 29 Mar 2018 13:33:39 +0200, Valentin Korenblit wrote:
>
>> +config BR2_PACKAGE_MESA3D_LLVM
>> +	bool "mesa3d w/ llvm"
> We're already under the mesa3d option, so repeating mesa3d in the
> prompt is not useless. Just "llvm support" is enough.
>
> Should the option be: bool "llvmpipe" ? Or is LLVM used by mesa3d for
> something else ?

We could leave "LLVM" because llvmpipe is not the only feature, r600 needs
llvm AMDGPU backend when llvm is selected, and then we could add radeonsi
Gallium Driver for newer GPUs.

>> +	depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS
>> +	select BR2_PACKAGE_LLVM
>> +
>> +comment "mesa3d w/ llvm needs llvm"
>> +	depends on !BR2_PACKAGE_LLVM_ARCH_SUPPORTS
> This comment doesn't make sense: BR2_PACKAGE_LLVM_ARCH_SUPPORTS is an
> architecture limitation, and therefore that the user can do about it.
> Just drop this comment.

Ok, perfect.

>
> Thanks,
>
> Thomas

Thanks,

Valentin