[Buildroot] [PATCH v4 09/11] package/libclc: new package

[Thomas Petazzoni]

Hello,

On Tue, 3 Apr 2018 14:27:16 +0200, Valentin Korenblit wrote:

> >> As OpenCL kernels are built dynamically on the target using libClang and
> >> libLLVM, it is necessary to copy /usr/include/clc from STAGING_DIR to the
> >> target manually, as Buildroot doesn't include this directory.  
> > I don't see where your .mk file is doing this. And it wouldn't work
> > because Buildroot removes $(TARGET_DIR)/usr/include entirely in its
> > target-finalize step.
> >
> > When you say "manually", do you mean that you have to
> > copy /usr/include/clc from your build machine to your target once the
> > target has booted ? If that's the case, then we really have a problem
> > here, the target should just work.  
> 
> Exactly, I was doing it manually after booting. Mesa uses pkg-config to
> get the includedir of libclc: https://pastebin.com/adzL8vd4
> 
> Do you think it is ok to override configure.ac from Mesa to specify
> another path? And in that case, where should I place all these headers?

Most likely yes, they should be in another folder, but I would need to
have a look. Could you push to some public Git repository the latest
status of your LLVM patch series, so that I can do a build, and see
what it looks like ?

> >> +LIBCLC_VERSION = 00236279a293b3737dee08c14f25923a889d2795
> >> +LIBCLC_SITE = https://git.llvm.org/git/libclc
> >> +LIBCLC_SITE_METHOD = git  
> > I assume they don't have a stable release you could use ?  
> 
> There is release_38, but the last commit is from 2 years ago. Master
> has some recent activity.

OK. Then just add a comment above that says exactly this.

> >> +LIBCLC_DEPENDENCIES = host-clang host-llvm
> >> +LIBCLC_INSTALL_STAGING = YES
> >> +
> >> +# C++ compiler is used to build a small tool (prepare-builtins) for the host.
> >> +# It must be built with the C++ compiler from the host, simply use
> >> +# HOSTCXX_NOCCACHE.  
> > Why not HOSTCXX ?

Did you notice this comment as well ? :-)

> >> +LIBCLC_CONF_OPTS = --with-llvm-config=$(HOST_DIR)/usr/bin/llvm-config \  
> > Why are you using the version in HOST_DIR, and not the one in
> > STAGING_DIR ?  
> 
> I will check this.

OK. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com