[Buildroot] [PATCH] [RFC] core/download: fix when the BR2_DL_DIR does not accept hardlinks

Peter Korsgaard peter at korsgaard.com
Tue Apr 3 20:45:44 UTC 2018


>>>>> "Yann" == Yann E MORIN <yann.morin.1998 at free.fr> writes:

 > When the BR2_DL_DIR is a mountpoint (presumably shared between various
 > machine, or mounted from the local host when running in a VM), it is
 > possible that it does not support hardlinks (e.g. samba, or the VMWare
 > VMFS, etc...).

 > If the hardlink fails, fallback to copying the file. As a last resort,
 > if that also fails, eventually fallback to doing the download.

 > Note: this means that the dl-wrapper is no longer atomic-safe: the code
 > suffers of a TOCTTOU condition: the file may be created in-between the
 > check and the moment we try to ln/cp it. Fortnately, the dl-wrapper is

s/Fortnately/Fortunately/

Committed, thanks.

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list