[Buildroot] [PATCH 1/2] cramfs: change to new site location
Matthew Weber
matthew.weber at rockwellcollins.com
Fri Apr 6 15:36:12 UTC 2018
Chris,
On Fri, Apr 6, 2018 at 10:02 AM, Chris Brandt <Chris.Brandt at renesas.com> wrote:
> Hello Matthew,
>
> On Thursday, April 05, 2018, Matthew Weber wrote:
>> > I don't have any big endian systems, so I can't test it either.
>> >
>> > But, Nicolas said that if someone is willing to test it and sign off on
>> > it, he would add it to his repository.
>>
>> Hi, I ran into a bug in the existing buildroot cramfs fs support for
>> big endian and Thomas pointed me at this patchset. I've
>> updated/tested my local build with your patches and included the big
>> endian fix.
>>
>> Feel free to pull this patch into your patchset (or hopefully upstream
>> merges first :-) )
>> https://patchwork.ozlabs.org/patch/895499/
>>
>> Upstream of an updated big endian support patch
>> https://github.com/npitre/cramfs-tools/pull/1
>>
>> Tested-by: Matt Weber <matthew.weber at rockwellcollins.com>
>
>
> Great! I struggled with trying to get a PowerPC QEMU up and running, so
> I never completed this task.
>
> However, I will say this: When discussing to incorporate that old endian
> patch back into Nicolas's repo, he requested that the new functions
> have a more proper prefix like swap_xxx. The names "fix_xxx" are not really
> good names to describe what they are doing.
>
Wanted to comment my patch is a newer version of an upstream patch and
not the old Buildroot patch. However I do see that naming is similar
in this patch. I'll update fix -> swap.
Matt
More information about the buildroot
mailing list