[Buildroot] [PATCH 1/1] python-fastentrypoints: new package

Asaf Kahlon asafka7 at gmail.com
Mon Apr 9 15:54:50 UTC 2018


Yegor, Thomas,

Indeed this is a host package. After you compile it, it can be used to
speed up entry points.
I now see Buildroot uses Config.in.host for this kind of packages, so I can
fix this on a new patch.

About the license - I saw the license file on the Github repository, but
this license is not provided on the tar.gz archive downloaded from pypi, so
how can I add the licence information?

Regards,
Asaf.

On Mon, Apr 9, 2018, 10:14 Thomas Petazzoni <thomas.petazzoni at bootlin.com>
wrote:

> Hello,
>
> On Sun, 8 Apr 2018 22:59:32 +0200, Yegor Yefremov wrote:
>
> > On Sun, Apr 8, 2018 at 7:48 PM, Asaf Kahlon <asafka7 at gmail.com> wrote:
> > > host-package that is able to shorten the load time of entry_points
> declared
> > > in setup.py of python packages.
> > >
> > > Unfortunately, license file was not found.
> >
> > This comment shouldn't be part of the commit log.
>
> I disagree, this comment makes sense in a commit log.
>
>
> > > diff --git a/package/python-fastentrypoints/Config.in
> b/package/python-fastentrypoints/Config.in
> > > new file mode 100644
> > > index 0000000000..d2c86dbc5e
> > > --- /dev/null
> > > +++ b/package/python-fastentrypoints/Config.in
> > > @@ -0,0 +1,6 @@
> > > +config BR2_PACKAGE_PYTHON_FASTENTRYPOINTS
> > > +       bool "python-fastentrypoints"
> > > +       help
> > > +         Makes entry_points specified in setup.py load more quickly.
> > > +
> > > +         https://github.com/ninjaaron/fast-entry_points
>
> So we have a Config.in option for a target package.
>
> > > +PYTHON_FASTENTRYPOINTS_VERSION = 0.10
> > > +PYTHON_FASTENTRYPOINTS_SOURCE =
> fastentrypoints-$(PYTHON_FASTENTRYPOINTS_VERSION).tar.gz
> > > +PYTHON_FASTENTRYPOINTS_SITE =
> https://pypi.python.org/packages/e8/c8/c2902c9c9da43d8be8c75a730f15f0c51933c42c39b91d1d7b605a88e907
> > > +PYTHON_FASTENTRYPOINTS_SETUP_TYPE = setuptools
> >
> > The license file can be found on github and seems to be BSD-2c [1]
> >
> > With these changes applied you can add my: Reviewed-by: Yegor Yefremov
> > <yegorslists at googlemail.com>
> >
> > [1] https://github.com/ninjaaron/fast-entry_points/blob/master/LICENSE
> >
> > Yegor
> >
> > > +
> > > +$(eval $(host-python-package))
>
> But this is a host only package ?
>
> I don't see how this can work. Am I missing something ?
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180409/0bf6f86f/attachment-0002.html>


More information about the buildroot mailing list