[Buildroot] [PATCH] Added option to enable Freedreno gallium driver in mesa3d

Thomas Petazzoni thomas.petazzoni at bootlin.com
Thu Apr 12 11:38:05 UTC 2018


Hello Andre,

Thanks for this new version, this is almost good, but not yet :)

On Thu, 12 Apr 2018 09:27:41 +1200, Andre Renaud wrote:
> From: Andre Renaud <arenaud at designa-electronics.com>
> 

Your Signed-off-by line is missing here, could you resend with this
Signed-off-by line added ?

Also, please change the commit title to:

	mesa3d: add option to enable Freedreno gallium driver

Indeed:

 - We also want the commit log to have the format "<package>:
   <description>"

 - Using a past tense "Added" doesn't make a lot of sense. Your commit
   has not "added" something, it is adding something. So using just
   "add" makes a lot more sense

Could you resend after fixing those minor issues? I had fixed myself
the commit title issue and was about to push your patch, but the
missing Signed-off-by requires you to resend a new version.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list