[Buildroot] [PATCH 1/1] tcf-agent: bump to version 1.7.0

Thomas Petazzoni thomas.petazzoni at bootlin.com
Fri Apr 13 11:18:52 UTC 2018


Hello,

On Fri, 13 Apr 2018 11:32:52 +0200, Norbert Lange wrote:

> There aren't any features of CMake used,
> not for detecting libraries, not for detecting headers, not for getting flags,
> all of this is missing compared to the Makefile. All that's there is a
> subset of the fixed flags + logic from other buildsystems.
> If that's an improvement for you, then there's not much left to discuss.
> 
> Proper CMake support would need all that (at which point it is surely
> better than make),
> and I expect you will get alot of warnings now in builds, since some
> feature detection macros are missing.

I build tcf-agent 1.7.0, using the patch provided by Eugene, and it
built without warnings.

> I wont add proper CMake support myself (as I first considered it), as
> I would have to dissect the information form other build-systems,
> and keep it current every new version.

Maybe we should just ask Eugene was is the official and
upstream-supported build system for tcf-agent. Using CMake instead of
hand-written Makefiles definitely makes a lot of sense. It does work
today, and if there are some issues with it, they can be fixed.

Look at your patch that was fixing the static linking issue with
OpenSSL. CMake has built-in support for detecting libraries using
pkg-config, automatically solving such static linking issues.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list