[Buildroot] [RFC PATCH 2/3] download/git: recover dirty cache

Ricardo Martincoski ricardo.martincoski at gmail.com
Tue Apr 17 08:56:02 UTC 2018


Hello,

On Tue, Apr 17, 2018 at 05:10 AM, Arnout Vandecappelle wrote:

> On 17-04-18 09:04, Ricardo Martincoski wrote:

Thank you for your comments.

>> Here is a squashed, no commit log, no comments on the code, hackish preview:
>> https://gitlab.com/RicardoMartincoski/buildroot/commit/f4e20bb62b761bb6c82a29acbd2f8d56d90e4e9c
> 
>  Looks good to me, with the following mods:
> 
> * use GIT_DIR
> * add comment above git init explaining that it is safe

> * explain why -ff is needed for git clean
> * Removing the shallow fetch should be done in a separate patch (I'm not
> entirely convinced yet that it is needed).

These 2 are already covered by Yann's WIP series, with comments and proper
commit logs:
https://git.buildroot.org/~ymorin/git/buildroot/log/?h=yem/git-robust

Regards,
Ricardo


More information about the buildroot mailing list