[Buildroot] [PATCH 2/2] lz4: improve static only build support
Baruch Siach
baruch at tkos.co.il
Fri Apr 20 04:31:52 UTC 2018
Hi Thomas,
On Thu, Apr 19, 2018 at 10:50:17PM +0200, Thomas Petazzoni wrote:
> On Thu, 19 Apr 2018 12:46:36 +0300, Baruch Siach wrote:
> > The current method of supporting static only build, removal of all lines
> > that match the SHARED regex from lib/Makefile, is crude and fragile.
> > Instead, patch lib/Makefile to allow disable of shared libraries.
> >
> > Signed-off-by: Baruch Siach <baruch at tkos.co.il>
>
> Thanks for cleaning this up, looks like a good idea. However...
>
> > +LZ4_MAKE_OPTS = DESTDIR=$(STAGING_DIR) PREFIX=/usr
>
> This looks weird. Why is DESTDIR needed at build time ? And how a
> DESTDIR=$(STAGING_DIR) in the INSTALL_TARGET_CMDS be the correct thing ?
It is not. Thanks for spotting. I'll fix and resend.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
More information about the buildroot
mailing list