[Buildroot] [PATCH] download/git: fix transform regexp for older tar versions

Thomas Petazzoni thomas.petazzoni at bootlin.com
Fri Apr 20 08:56:07 UTC 2018


Hello,

On Fri, 20 Apr 2018 09:36:32 +0200, Yann E. MORIN wrote:
> Older versions of tar (e.g. 1.27.1) incorrectly interpret the escaping
> of the regexp separator, and generate broken tarballs.
> 
> For example, given the following transform expression:
>     --transform="s/^\.\//squashfs-e38956b92f738518c29734399629e7cdb33072d3\//"
> 
> the resulting paths in the generated tarball would be:
>     squashfs-e38956b92f738518c29734399629e7cdb33072d3\/
> 
> i.e. a directory which last character is indeed a '\'.
> 
> We fix that by using a separator which is very unlikely to occur in a
> filename.
> 
> Fixes:
>     http://autobuild.buildroot.org/results/742/7427f34e5c9f6d043b0fe6ad2c66cc0f31d2b24f/
> 
> and probably a slew of others as well...
> 
> Take this opportunity to fix indetation on the following line (leading
> spaces, not tABs).
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Cc: Ricardo Martincoski <ricardo.martincoski at gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
> Cc: Maxime Hadjinlian <maxime.hadjinlian at gmail.com>
> ---
>  support/download/git | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list